Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rtl_433: 20.11 -> 21.05 #122780

Merged
merged 2 commits into from May 16, 2021
Merged

rtl_433: 20.11 -> 21.05 #122780

merged 2 commits into from May 16, 2021

Conversation

Mindavi
Copy link
Contributor

@Mindavi Mindavi commented May 12, 2021

Motivation for this change

Upstream release: https://github.com/merbanan/rtl_433/releases/tag/21.05

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@r-rmcgibbo
Copy link

Result of nixpkgs-review pr 122780 at 548818a run on x86_64-linux 1

1 package built successfully:
  • rtl_433
1 suggestion:
  • warning: unclear-gpl

    gpl2 is a deprecated license, please check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.

    Near pkgs/applications/radio/rtl_433/default.nix:25:5:

       |
    25 |     license = licenses.gpl2;
       |     ^
    

@ofborg ofborg bot requested a review from earldouglas May 15, 2021 13:43
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/378

@AndersonTorres AndersonTorres merged commit b3a8cab into NixOS:master May 16, 2021
@Mindavi Mindavi deleted the rtl_433/21.05 branch May 16, 2021 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants