Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

croc: 9.1.3 -> 9.1.4 #122790

Merged
merged 1 commit into from May 15, 2021
Merged

croc: 9.1.3 -> 9.1.4 #122790

merged 1 commit into from May 15, 2021

Conversation

equirosa
Copy link
Contributor

Motivation for this change

New version released: https://github.com/schollz/croc/releases/tag/v9.1.4

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from kalbasit and HugoReeves May 13, 2021 01:35
@karolchmist
Copy link
Member

Result of nixpkgs-review pr 122790 run on x86_64-linux 1

1 package built:
  • croc

@karolchmist
Copy link
Member

It builds and it works, test passes 👍

@SuperSandro2000 SuperSandro2000 merged commit 7dc8db5 into NixOS:master May 15, 2021
@equirosa equirosa deleted the croc branch September 27, 2023 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karolchmist karolchmist karolchmist approved these changes

@kalbasit kalbasit Awaiting requested review from kalbasit

@HugoReeves HugoReeves Awaiting requested review from HugoReeves

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@equirosa @karolchmist @SuperSandro2000