Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

llvm*: patch to fix a test on older CPUs #122803

Merged
merged 1 commit into from May 14, 2021
Merged

llvm*: patch to fix a test on older CPUs #122803

merged 1 commit into from May 14, 2021

Conversation

vcunat
Copy link
Member

@vcunat vcunat commented May 13, 2021

  • 10, 11, 12: use the upstream patch
  • 9: use Luke's patch as the upstream patch won't apply
Motivation for this change

I recalled this when the old machine got back in Hydra :-) but it won't hurt to fix this in any case.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@vcunat
llvm*: patch to fix a test on older CPUs
ea306f6 
- 10, 11, 12: use the upstream patch
- 9: use Luke's patch as the upstream patch won't apply
@vcunat vcunat requested a review from matthewbauer as a code owner May 13, 2021 08:53
@vcunat vcunat mentioned this pull request May 13, 2021
Closed
10 tasks
@vcunat
Copy link
Member Author

vcunat commented May 13, 2021

The uops-CMOV16rm-noreg.s doesn't exist on LLVM 8 and earlier and I can't see those touched in the previous PR, so I hope those are OK.

7c6f434c
7c6f434c approved these changes May 13, 2021
View reviewed changes
Copy link
Member

@7c6f434c 7c6f434c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@vcunat vcunat merged commit 1a7ef60 into NixOS:staging May 14, 2021
@vcunat
Copy link
Member Author

vcunat commented May 14, 2021

I couldn't bear watching the failures for long :-)

@vcunat vcunat deleted the p/llvm-wendy branch May 14, 2021 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@7c6f434c 7c6f434c 7c6f434c approved these changes

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

@lovek323 lovek323 Awaiting requested review from lovek323

@primeos primeos Awaiting requested review from primeos

@dtzWill dtzWill Awaiting requested review from dtzWill

Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vcunat @7c6f434c