.github/workflows/merge-staging.yml: Include branch in comment #122814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If I receive the mail notification that staging(-next) merge failed, I either need to check `git log staging-next` or click the action run link to find out where should I resolve the conflict. To save time, let’s include the information about which step failed right in the comment.
jtojnar
force-pushed
the
staging-merge-comment
branch
from
a5a44ed
to
6225647
Compare
|
Switched from JSON object access fromJSON('{"true-false": " from master to staging-next", "false-true": " from staging-next to staging"}, "false-false": ""}')[format('{0}-{1}', steps.staging_next.outcome == 'failure', steps.staging.outcome == 'failure')]to short-circuiting boolean operators, which makes it almost slick: (steps.staging_next.outcome == 'failure' && ' from master to staging-next') || ((steps.staging.outcome == 'failure' && ' from staging-next to staging') || '') |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
If I receive the mail notification that staging(-next) merge failed, I either need to check
git log staging-nextor click the action run link to find out where should I resolve the conflict.To save time, let’s include the information about which step failed right in the comment.
Things done
Tested in: jtojnar/repro#2