Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opensmtpd-filter-rspamd: init at 0.1.7 #122823

Merged
merged 1 commit into from May 19, 2021

Conversation

Flakebi
Copy link
Member

@Flakebi Flakebi commented May 13, 2021

Motivation for this change

A filter to integrate rspamd with opensmtpd: https://github.com/poolpOrg/filter-rspamd

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Member

@Ekleog Ekleog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks interesting, thank you! Do you think you could add a test based on nixos/tests/opensmtpd.nix (feel free to copy/paste it into another file, it should just be a matter of copy-pasting, adding the required configuration lines and adding a grep in the check-it-works script), so that it is easy to check that this package keeps working and being compatible with opensmtpd as time pass?

(And then add it to nixos/tests/all-tests.nix and to the passthru.tests attribute of the derivation you added so it gets automatically tested by our infrastructure)

(Just FYI, there was #122403 aiming at the same thing, but it looks like the author there doesn't want to commit to maintaining this package, so it would probably be better to merge your version :))

pkgs/servers/mail/opensmtpd/filter-rspamd.nix Outdated Show resolved Hide resolved
@Flakebi
Copy link
Member Author

Flakebi commented May 15, 2021

Thanks for the review, I added a test.

The last time I checked there was no other pr yet, seems like @wizeman and me ended up writing exactly the same code :)

@Ekleog
Copy link
Member

Ekleog commented May 19, 2021

Awesome, thank you!

@Ekleog Ekleog merged commit 68c618c into NixOS:master May 19, 2021
@Flakebi Flakebi deleted the opensmtpd-filter-rspamd branch May 19, 2021 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants