New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
opensmtpd-filter-rspamd: init at 0.1.7 #122823
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks interesting, thank you! Do you think you could add a test based on nixos/tests/opensmtpd.nix (feel free to copy/paste it into another file, it should just be a matter of copy-pasting, adding the required configuration lines and adding a grep in the check-it-works script), so that it is easy to check that this package keeps working and being compatible with opensmtpd as time pass?
(And then add it to nixos/tests/all-tests.nix and to the passthru.tests attribute of the derivation you added so it gets automatically tested by our infrastructure)
(Just FYI, there was #122403 aiming at the same thing, but it looks like the author there doesn't want to commit to maintaining this package, so it would probably be better to merge your version :))
7ff67da
to
d26067b
Compare
d26067b
to
9171063
Compare
Thanks for the review, I added a test. The last time I checked there was no other pr yet, seems like @wizeman and me ended up writing exactly the same code :) |
b1fde18
to
419daaa
Compare
Awesome, thank you! |
Motivation for this change
A filter to integrate rspamd with opensmtpd: https://github.com/poolpOrg/filter-rspamd
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)