Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Postman: 7.36.1 -> 8.4.0, add libdrm and mesa which were missing (according #111382) #122845

Merged
merged 1 commit into from May 14, 2021
Merged

Postman: 7.36.1 -> 8.4.0, add libdrm and mesa which were missing (according #111382) #122845

merged 1 commit into from May 14, 2021

Conversation

SebTM
Copy link
Contributor

@SebTM SebTM commented May 13, 2021

Motivation for this change

Getting latest version of Postman

Things done

Updated version and hashes, tested (failed), added missing libraries and tested successful.

  • [?] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s) -> Enabled by default so assuming yes
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after) - About 5 MB diff?
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@r-rmcgibbo
Copy link

Result of nixpkgs-review pr 122845 at 72548d6 run on x86_64-linux 1

1 package built successfully:
  • postman
1 suggestion:
  • warning: missing-phase-hooks

    installPhase should probably contain runHook preInstall and runHook postInstall.

    Near pkgs/development/web/postman/default.nix:70:3:

       |
    70 |   installPhase = ''
       |   ^
    

@Ma27 Ma27 merged commit 5817a05 into NixOS:master May 14, 2021
@SebTM SebTM deleted the update/postman branch January 6, 2022 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants