Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reposurgeon: 3.44 -> 4.26 #122854

Merged
merged 1 commit into from May 30, 2021
Merged

Conversation

dguibert
Copy link
Member

@dguibert dguibert commented May 13, 2021

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@r-rmcgibbo
Copy link

r-rmcgibbo commented May 13, 2021

Result of nixpkgs-review pr 122854 at bd752b94 run on aarch64-linux 1

1 package built successfully:
  • reposurgeon
11 suggestions:
  • warning: unused-argument

    Unused argument: monotone.
    Near pkgs/applications/version-management/reposurgeon/default.nix:4:21:

      |
    4 | , mercurial ? null, monotone ? null, rcs ? null
      |                     ^
    
  • warning: unused-argument

    Unused argument: cvs_fast_export.
    Near pkgs/applications/version-management/reposurgeon/default.nix:5:22:

      |
    5 | , subversion ? null, cvs_fast_export ? null }:
      |                      ^
    
  • warning: unused-argument

    Unused argument: makeWrapper.
    Near pkgs/applications/version-management/reposurgeon/default.nix:1:26:

      |
    1 | { lib, stdenv, fetchurl, makeWrapper, buildGoModule, git
      |                          ^
    
  • warning: unused-argument

    Unused argument: cvs.
    Near pkgs/applications/version-management/reposurgeon/default.nix:3:18:

      |
    3 | , breezy ? null, cvs ? null, darcs ? null, fossil ? null
      |                  ^
    
  • warning: unused-argument

    Unused argument: subversion.
    Near pkgs/applications/version-management/reposurgeon/default.nix:5:3:

      |
    5 | , subversion ? null, cvs_fast_export ? null }:
      |   ^
    
  • warning: unused-argument

    Unused argument: mercurial.
    Near pkgs/applications/version-management/reposurgeon/default.nix:4:3:

      |
    4 | , mercurial ? null, monotone ? null, rcs ? null
      |   ^
    
  • warning: unused-argument

    Unused argument: darcs.
    Near pkgs/applications/version-management/reposurgeon/default.nix:3:30:

      |
    3 | , breezy ? null, cvs ? null, darcs ? null, fossil ? null
      |                              ^
    
  • warning: unused-argument

    Unused argument: rcs.
    Near pkgs/applications/version-management/reposurgeon/default.nix:4:38:

      |
    4 | , mercurial ? null, monotone ? null, rcs ? null
      |                                      ^
    
  • warning: unused-argument

    Unused argument: breezy.
    Near pkgs/applications/version-management/reposurgeon/default.nix:3:3:

      |
    3 | , breezy ? null, cvs ? null, darcs ? null, fossil ? null
      |   ^
    
  • warning: unused-argument

    Unused argument: git.
    Near pkgs/applications/version-management/reposurgeon/default.nix:1:54:

      |
    1 | { lib, stdenv, fetchurl, makeWrapper, buildGoModule, git
      |                                                      ^
    
  • warning: unused-argument

    Unused argument: fossil.
    Near pkgs/applications/version-management/reposurgeon/default.nix:3:44:

      |
    3 | , breezy ? null, cvs ? null, darcs ? null, fossil ? null
      |                                            ^
    

Result of nixpkgs-review pr 122854 at bd752b94 run on x86_64-linux 1

1 package built successfully:
  • reposurgeon
11 suggestions:
  • warning: unused-argument

    Unused argument: breezy.
    Near pkgs/applications/version-management/reposurgeon/default.nix:3:3:

      |
    3 | , breezy ? null, cvs ? null, darcs ? null, fossil ? null
      |   ^
    
  • warning: unused-argument

    Unused argument: cvs.
    Near pkgs/applications/version-management/reposurgeon/default.nix:3:18:

      |
    3 | , breezy ? null, cvs ? null, darcs ? null, fossil ? null
      |                  ^
    
  • warning: unused-argument

    Unused argument: mercurial.
    Near pkgs/applications/version-management/reposurgeon/default.nix:4:3:

      |
    4 | , mercurial ? null, monotone ? null, rcs ? null
      |   ^
    
  • warning: unused-argument

    Unused argument: git.
    Near pkgs/applications/version-management/reposurgeon/default.nix:1:54:

      |
    1 | { lib, stdenv, fetchurl, makeWrapper, buildGoModule, git
      |                                                      ^
    
  • warning: unused-argument

    Unused argument: cvs_fast_export.
    Near pkgs/applications/version-management/reposurgeon/default.nix:5:22:

      |
    5 | , subversion ? null, cvs_fast_export ? null }:
      |                      ^
    
  • warning: unused-argument

    Unused argument: monotone.
    Near pkgs/applications/version-management/reposurgeon/default.nix:4:21:

      |
    4 | , mercurial ? null, monotone ? null, rcs ? null
      |                     ^
    
  • warning: unused-argument

    Unused argument: rcs.
    Near pkgs/applications/version-management/reposurgeon/default.nix:4:38:

      |
    4 | , mercurial ? null, monotone ? null, rcs ? null
      |                                      ^
    
  • warning: unused-argument

    Unused argument: darcs.
    Near pkgs/applications/version-management/reposurgeon/default.nix:3:30:

      |
    3 | , breezy ? null, cvs ? null, darcs ? null, fossil ? null
      |                              ^
    
  • warning: unused-argument

    Unused argument: makeWrapper.
    Near pkgs/applications/version-management/reposurgeon/default.nix:1:26:

      |
    1 | { lib, stdenv, fetchurl, makeWrapper, buildGoModule, git
      |                          ^
    
  • warning: unused-argument

    Unused argument: fossil.
    Near pkgs/applications/version-management/reposurgeon/default.nix:3:44:

      |
    3 | , breezy ? null, cvs ? null, darcs ? null, fossil ? null
      |                                            ^
    
  • warning: unused-argument

    Unused argument: subversion.
    Near pkgs/applications/version-management/reposurgeon/default.nix:5:3:

      |
    5 | , subversion ? null, cvs_fast_export ? null }:
      |   ^
    

@SuperSandro2000 SuperSandro2000 merged commit fa01448 into NixOS:master May 30, 2021
@dguibert dguibert deleted the dg/reposurgeon branch August 29, 2021 09:04
@dguibert dguibert restored the dg/reposurgeon branch November 3, 2021 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants