Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mail-parser: Remove invalid requirements.txt patch #122875

Merged
merged 1 commit into from May 13, 2021

Conversation

polygon
Copy link
Contributor

@polygon polygon commented May 13, 2021

Upstream modified requirements.txt and is no longer pinning
dependencies to exact versions. Instead, it provides version
bounds. Also, the ipaddress dependency is now limited already
in requirements.txt to Python versions < 3.3.

Removed all the patching since it generated an invalid
requirements.txt that caused the build to fail.

Motivation for this change

Build fails since updating from 3.12.0 to 3.15.0. Patching from Nix-derivation would create an invalid requirements.txt after upstream changes to that file.

ZHF: #122042

@jonringer

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Upstream modified requirements.txt and is no longer pinning
dependencies to exact versions. Instead, it provides version
bounds. Also, the ipaddress dependency is now limited already
in requirements.txt to Python versions < 3.3.

Removed all the patching since it generated an invalid
requirements.txt that caused the build to fail.
@r-rmcgibbo
Copy link

r-rmcgibbo commented May 13, 2021

Result of nixpkgs-review pr 122875 at 652e738 run on aarch64-linux 1

2 packages built successfully:
  • python38Packages.mail-parser
  • python39Packages.mail-parser

Result of nixpkgs-review pr 122875 at 652e738 run on x86_64-linux 1

2 packages built successfully:
  • python38Packages.mail-parser
  • python39Packages.mail-parser

Copy link
Contributor

@risicle risicle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WFM macos 10.15 & nixos x86_64

@risicle risicle merged commit 091f7e0 into NixOS:master May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants