fancy-motd: init at unstable-2021-05-15

[rhoriguchi]

Things done

• Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Determined the impact on package closure size (by running nix path-info -S before and after)
• Ensured that relevant documentation is up to date
• Fits CONTRIBUTING.md.

[legendofmiracles]

While this builds, when I try to run this i always get this error, regardless of if it's installed inside with my user profile or inside the nix-review shell:

$ motd
/nix/store/02c63zqrbzqbrxk4nr2qy4zxki6i30gm-fancy-motd-20211305/lib/framework.sh: line 2: /nix/store/02c63zqrbzqbrxk4nr2qy4zxki6i30gm-fancy-motd-20211305/lib/config.sh: No such file or directory

[r-rmcgibbo]

Result of nixpkgs-review pr 122885 at 45f8fbad run on x86_64-linux 1

1 package built successfully:

• fancy-motd

2 suggestions:

• warning: build-tools-in-build-inputs

  bc is a build tool so it likely goes to nativeBuildInputs, not buildInputs.

  Near pkgs/tools/system/fancy-motd/default.nix:14:3:

     |
  14 |   buildInputs = [ bc curl figlet fortune gawk iproute2 ];
     |   ^
  

• warning: missing-phase-hooks

  installPhase should probably contain runHook preInstall and runHook postInstall.

  Near pkgs/tools/system/fancy-motd/default.nix:27:3:

     |
  27 |   installPhase = ''
     |   ^
  

[rhoriguchi]

While this builds, when I try to run this i always get this error, regardless of if it's installed inside with my user profile or inside the nix-review shell:

$ motd
/nix/store/02c63zqrbzqbrxk4nr2qy4zxki6i30gm-fancy-motd-20211305/lib/framework.sh: line 2: /nix/store/02c63zqrbzqbrxk4nr2qy4zxki6i30gm-fancy-motd-20211305/lib/config.sh: No such file or directory

I've made some upstream changes today and forgot to include the config.sh. It should work now if you run motd.

[legendofmiracles]

Result of nixpkgs-review pr 122885 run on x86_64-linux 1

1 package built:

• fancy-motd

Works now for me too 🎉
Thanks for packaging this!