Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

starboard: 0.10.1 -> 0.10.2 -> 0.10.3 #122888

Merged
merged 2 commits into from Jun 4, 2021
Merged

Conversation

06kellyjac
Copy link
Member

@06kellyjac 06kellyjac commented May 13, 2021

Motivation for this change

Bump starboard to 0.10.2 0.10.3

Also standardize with my other packages
set buildArrayFlags in bash
run starboard tests
add installCheckPhase
have litteral url
add changelog

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@06kellyjac
Copy link
Member Author

Result of nixpkgs-review pr 122888 run on x86_64-linux 1

1 package built:
  • starboard

@06kellyjac 06kellyjac changed the title starboard: 0.10.1 -> 0.10.2 starboard: 0.10.1 -> 0.10.2 -> 0.10.3 May 14, 2021
@06kellyjac
Copy link
Member Author

/marvin opt-in
/status needs_reviewer

@marvin-mk2 marvin-mk2 bot added the marvin label Jun 4, 2021
@marvin-mk2
Copy link

marvin-mk2 bot commented Jun 4, 2021

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@kevincox kevincox merged commit da05be8 into NixOS:master Jun 4, 2021
@06kellyjac 06kellyjac deleted the starboard branch June 4, 2021 12:40
@06kellyjac
Copy link
Member Author

🚀 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants