-
-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ruby-2.0.0p247 #1229
Closed
Closed
ruby-2.0.0p247 #1229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps the ruby 2.0.0 version and fixes build on OSX
PS: The fixes are really just copied over from the ruby19.nix file |
👍 |
Closed
Closing in favor of #1272 |
emilazy
added a commit
to emilazy/nixpkgs
that referenced
this pull request
Apr 22, 2020
7-Zip's RAR implementation is built on the non-free UnRAR source code; DOC/License.txt says: Licenses for files are: 1) CPP/7zip/Compress/Rar* files: GNU LGPL + unRAR restriction 2) All other files: GNU LGPL The GNU LGPL + unRAR restriction means that you must follow both GNU LGPL rules and unRAR restriction rules. ... unRAR restriction ----------------- The decompression engine for RAR archives was developed using source code of unRAR program. All copyrights to original unRAR code are owned by Alexander Roshal. The license for original unRAR code has the following restriction: The unRAR sources cannot be used to re-create the RAR compression algorithm, which is proprietary. Distribution of modified unRAR sources in separate form or as a part of other software is permitted, provided that it is clearly stated in the documentation and source comments that the code may not be used to develop a RAR (WinRAR) compatible archiver. The unrar licensing is [infamously restrictive and non-free][fedora]; it's inappropriate for us to keep the RAR support while labelling the package as free software (and indeed there's a commented-out line pointing out that the current `meta.license` is false). Unfortunately, the 7-Zip upstream seems uninterested in replacing the code with a freely-licensed alternative (see [7-Zip ticket NixOS#1229][7zip]). [fedora]: https://fedoraproject.org/wiki/Licensing:Unrar [7zip]: https://sourceforge.net/p/sevenzip/feature-requests/1229/ An alternative solution would be to mark the p7zip package as non-free instead; I decided not to because its other functionality (especially `.7z` support) is freely-licensed and useful, and there are free software alternatives for extracting RAR files (e.g. in nixpkgs there's `archiver`, which is written in a memory-safe language, and `unar`, which at least doesn't have two patches for CVEs that haven't been addressed upstream...). I checked that `7z(1)` fails gracefully on `.rar` files now: emily@renko ~/tmp> curl -L -O https://www.philippwinterberg.com/download/example.rar % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 5715k 100 5715k 0 0 6716k 0 --:--:-- --:--:-- --:--:-- 6716k emily@renko ~/tmp> 7z x example.rar 7-Zip [64] 16.02 : Copyright (c) 1999-2016 Igor Pavlov : 2016-05-21 p7zip Version 16.02 (locale=en_CA.UTF-8,Utf16=on,HugeFiles=on,64 bits,8 CPUs x64) Scanning the drive for archives: 1 file, 5853119 bytes (5716 KiB) Extracting archive: example.rar ERROR: example.rar Can not open the file as archive Can't open as archive: 1 Files: 0 Size: 0 Compressed: 0
alyssais
pushed a commit
that referenced
this pull request
Apr 22, 2020
7-Zip's RAR implementation is built on the non-free UnRAR source code; DOC/License.txt says: Licenses for files are: 1) CPP/7zip/Compress/Rar* files: GNU LGPL + unRAR restriction 2) All other files: GNU LGPL The GNU LGPL + unRAR restriction means that you must follow both GNU LGPL rules and unRAR restriction rules. ... unRAR restriction ----------------- The decompression engine for RAR archives was developed using source code of unRAR program. All copyrights to original unRAR code are owned by Alexander Roshal. The license for original unRAR code has the following restriction: The unRAR sources cannot be used to re-create the RAR compression algorithm, which is proprietary. Distribution of modified unRAR sources in separate form or as a part of other software is permitted, provided that it is clearly stated in the documentation and source comments that the code may not be used to develop a RAR (WinRAR) compatible archiver. The unrar licensing is [infamously restrictive and non-free][fedora]; it's inappropriate for us to keep the RAR support while labelling the package as free software (and indeed there's a commented-out line pointing out that the current `meta.license` is false). Unfortunately, the 7-Zip upstream seems uninterested in replacing the code with a freely-licensed alternative (see [7-Zip ticket #1229][7zip]). [fedora]: https://fedoraproject.org/wiki/Licensing:Unrar [7zip]: https://sourceforge.net/p/sevenzip/feature-requests/1229/ An alternative solution would be to mark the p7zip package as non-free instead; I decided not to because its other functionality (especially `.7z` support) is freely-licensed and useful, and there are free software alternatives for extracting RAR files (e.g. in nixpkgs there's `archiver`, which is written in a memory-safe language, and `unar`, which at least doesn't have two patches for CVEs that haven't been addressed upstream...). I checked that `7z(1)` fails gracefully on `.rar` files now: emily@renko ~/tmp> curl -L -O https://www.philippwinterberg.com/download/example.rar % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 5715k 100 5715k 0 0 6716k 0 --:--:-- --:--:-- --:--:-- 6716k emily@renko ~/tmp> 7z x example.rar 7-Zip [64] 16.02 : Copyright (c) 1999-2016 Igor Pavlov : 2016-05-21 p7zip Version 16.02 (locale=en_CA.UTF-8,Utf16=on,HugeFiles=on,64 bits,8 CPUs x64) Scanning the drive for archives: 1 file, 5853119 bytes (5716 KiB) Extracting archive: example.rar ERROR: example.rar Can not open the file as archive Can't open as archive: 1 Files: 0 Size: 0 Compressed: 0
adisbladis
pushed a commit
to adisbladis/nixpkgs
that referenced
this pull request
Apr 22, 2020
7-Zip's RAR implementation is built on the non-free UnRAR source code; DOC/License.txt says: Licenses for files are: 1) CPP/7zip/Compress/Rar* files: GNU LGPL + unRAR restriction 2) All other files: GNU LGPL The GNU LGPL + unRAR restriction means that you must follow both GNU LGPL rules and unRAR restriction rules. ... unRAR restriction ----------------- The decompression engine for RAR archives was developed using source code of unRAR program. All copyrights to original unRAR code are owned by Alexander Roshal. The license for original unRAR code has the following restriction: The unRAR sources cannot be used to re-create the RAR compression algorithm, which is proprietary. Distribution of modified unRAR sources in separate form or as a part of other software is permitted, provided that it is clearly stated in the documentation and source comments that the code may not be used to develop a RAR (WinRAR) compatible archiver. The unrar licensing is [infamously restrictive and non-free][fedora]; it's inappropriate for us to keep the RAR support while labelling the package as free software (and indeed there's a commented-out line pointing out that the current `meta.license` is false). Unfortunately, the 7-Zip upstream seems uninterested in replacing the code with a freely-licensed alternative (see [7-Zip ticket NixOS#1229][7zip]). [fedora]: https://fedoraproject.org/wiki/Licensing:Unrar [7zip]: https://sourceforge.net/p/sevenzip/feature-requests/1229/ An alternative solution would be to mark the p7zip package as non-free instead; I decided not to because its other functionality (especially `.7z` support) is freely-licensed and useful, and there are free software alternatives for extracting RAR files (e.g. in nixpkgs there's `archiver`, which is written in a memory-safe language, and `unar`, which at least doesn't have two patches for CVEs that haven't been addressed upstream...). I checked that `7z(1)` fails gracefully on `.rar` files now: emily@renko ~/tmp> curl -L -O https://www.philippwinterberg.com/download/example.rar % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 5715k 100 5715k 0 0 6716k 0 --:--:-- --:--:-- --:--:-- 6716k emily@renko ~/tmp> 7z x example.rar 7-Zip [64] 16.02 : Copyright (c) 1999-2016 Igor Pavlov : 2016-05-21 p7zip Version 16.02 (locale=en_CA.UTF-8,Utf16=on,HugeFiles=on,64 bits,8 CPUs x64) Scanning the drive for archives: 1 file, 5853119 bytes (5716 KiB) Extracting archive: example.rar ERROR: example.rar Can not open the file as archive Can't open as archive: 1 Files: 0 Size: 0 Compressed: 0 (cherry picked from commit 95f82e2)
stigok
pushed a commit
to stigok/nixpkgs
that referenced
this pull request
Jun 12, 2020
7-Zip's RAR implementation is built on the non-free UnRAR source code; DOC/License.txt says: Licenses for files are: 1) CPP/7zip/Compress/Rar* files: GNU LGPL + unRAR restriction 2) All other files: GNU LGPL The GNU LGPL + unRAR restriction means that you must follow both GNU LGPL rules and unRAR restriction rules. ... unRAR restriction ----------------- The decompression engine for RAR archives was developed using source code of unRAR program. All copyrights to original unRAR code are owned by Alexander Roshal. The license for original unRAR code has the following restriction: The unRAR sources cannot be used to re-create the RAR compression algorithm, which is proprietary. Distribution of modified unRAR sources in separate form or as a part of other software is permitted, provided that it is clearly stated in the documentation and source comments that the code may not be used to develop a RAR (WinRAR) compatible archiver. The unrar licensing is [infamously restrictive and non-free][fedora]; it's inappropriate for us to keep the RAR support while labelling the package as free software (and indeed there's a commented-out line pointing out that the current `meta.license` is false). Unfortunately, the 7-Zip upstream seems uninterested in replacing the code with a freely-licensed alternative (see [7-Zip ticket NixOS#1229][7zip]). [fedora]: https://fedoraproject.org/wiki/Licensing:Unrar [7zip]: https://sourceforge.net/p/sevenzip/feature-requests/1229/ An alternative solution would be to mark the p7zip package as non-free instead; I decided not to because its other functionality (especially `.7z` support) is freely-licensed and useful, and there are free software alternatives for extracting RAR files (e.g. in nixpkgs there's `archiver`, which is written in a memory-safe language, and `unar`, which at least doesn't have two patches for CVEs that haven't been addressed upstream...). I checked that `7z(1)` fails gracefully on `.rar` files now: emily@renko ~/tmp> curl -L -O https://www.philippwinterberg.com/download/example.rar % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 5715k 100 5715k 0 0 6716k 0 --:--:-- --:--:-- --:--:-- 6716k emily@renko ~/tmp> 7z x example.rar 7-Zip [64] 16.02 : Copyright (c) 1999-2016 Igor Pavlov : 2016-05-21 p7zip Version 16.02 (locale=en_CA.UTF-8,Utf16=on,HugeFiles=on,64 bits,8 CPUs x64) Scanning the drive for archives: 1 file, 5853119 bytes (5716 KiB) Extracting archive: example.rar ERROR: example.rar Can not open the file as archive Can't open as archive: 1 Files: 0 Size: 0 Compressed: 0 (cherry picked from commit 95f82e2)
This was referenced Sep 15, 2021
This was referenced Nov 4, 2022
This was referenced Nov 28, 2023
This was referenced May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps the ruby 2.0.0 version and fixes build on OSX.
It's my first PR so please be gentle :)