Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gnomeExtensions.caffeine: 37 -> 38 #122923

Merged
merged 1 commit into from May 17, 2021
Merged

gnomeExtensions.caffeine: 37 -> 38 #122923

merged 1 commit into from May 17, 2021

Conversation

rhoriguchi
Copy link
Contributor

Motivation for this change

Add GNOME 40 support. This update will break 3.36 and 3.38 support.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: GNOME GNOME desktop environment and its underlying platform label May 14, 2021
@ofborg ofborg bot requested a review from emanueleperuffo May 14, 2021 00:13
@r-rmcgibbo
Copy link

Result of nixpkgs-review pr 122923 at f3e6d6ba run on x86_64-linux 1

1 package built successfully:
  • gnomeExtensions.caffeine
2 suggestions:
  • warning: unused-argument

    Unused argument: gnome.
    Near pkgs/desktops/gnome/extensions/caffeine/default.nix:1:54:

      |
    1 | { lib, stdenv, fetchFromGitHub, glib, gettext, bash, gnome }:
      |                                                      ^
    
  • warning: unclear-gpl

    gpl2 is a deprecated license, please check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.

    Near pkgs/desktops/gnome/extensions/caffeine/default.nix:36:5:

       |
    36 |     license = licenses.gpl2;
       |     ^
    

@SuperSandro2000 SuperSandro2000 merged commit af67d7e into NixOS:master May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants