Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xfce.mousepad: 0.5.4 -> 0.5.5 #122989

Merged
merged 1 commit into from May 15, 2021
Merged

xfce.mousepad: 0.5.4 -> 0.5.5 #122989

merged 1 commit into from May 15, 2021

Conversation

romildo
Copy link
Contributor

@romildo romildo commented May 14, 2021

Motivation for this change
  • Update to version 0.5.5
  • Remove unused dependences: vala, xfconf
  • Add new dependence: gspell (for the new gspell plugin)
  • Use the GSettings keyfile backend
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

- Update to version 0.5.5
- Remove unused dependences: vala, xfconf
- Add new dependence: gspell (for the new gspell plugin)
- Use the GSettings keyfile backend
@r-rmcgibbo
Copy link

r-rmcgibbo commented May 14, 2021

Result of nixpkgs-review pr 122989 at 515ce02 run on x86_64-linux 1

1 package built successfully:
  • xfce.mousepad
1 suggestion:
  • warning: maintainers-missing

    Package does not have a maintainer. Consider adding yourself?

    Near lib/attrsets.nix:366:7:

        |
    366 |       value = f name (catAttrs name sets);
        |       ^
    

Result of nixpkgs-review pr 122989 at 515ce02 run on aarch64-linux 1

1 package built successfully:
  • xfce.mousepad

@SuperSandro2000 SuperSandro2000 merged commit ab38d4d into NixOS:master May 15, 2021
@romildo romildo deleted the upd.mousepad branch May 15, 2021 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants