New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
matrix-synapse: init at 0.12.0 #12301
Conversation
By analyzing the blame information on this pull request, we identified @edolstra, @joachifm and @offlinehacker to be potential reviewers |
That's a huge addition, thanks! Please check the travis error, daemonize doesn't build. Make sure you have enabled nix chroots. Also note that the uid 219 is no more available. |
8f12b7c
to
8fb3659
Compare
I changed the uid to 223, and fixed a build error concerning pydenticon missing mock (caught that by enabling chroot builds). Now I'm having a small problem. The sha256 returned by fetchgit seems to have changed from under my feets, even though the tag still points to the same commit. Any idea how this could happen ? https://github.com/roblabla/nixpkgs/blob/feature-initMatrixSynapse/pkgs/servers/matrix-synapse/default.nix#L17-L21 Yesterday : 29f3d95c0a5a0c902a1c37357dea1a9150d3177d17f1045e27a9d01692816af9 Is the reason it breaks because I'm using tag refs instead of a real commit hash ? |
@roblabla is fetchgit necessary? Use fetchFromGitHub if possible. |
8fb3659
to
7dcf4ff
Compare
Fixed, it's using fetchFromGitHub now. Also fixed a failure in pynacl due to missing pytest for the tests to pass. Hopefully, everything should pass now (I didn't catch any problem with daemonize locally). |
src = pkgs.fetchurl { | ||
url = "https://pypi.python.org/packages/source/T/Twisted/${name}.tar.bz2"; | ||
sha256 = "05agfp17cndhv2w0p559lvknl7nv0xqkg10apc47fm53m8llbfvz"; | ||
sha256 = "0zy18lcrris4aaslil5k12i13k56c32hzfdv6h10kbnzl026h158"; | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unless you tested with Nox what the effects are of this upgrade I suggest you add atwisted_15
instead and use that. We can then later see what other packages can use this latest twisted. The same with simplejson
since that's also a common package. Unless of course you run into collisions.
7f58928
to
c181792
Compare
@FRidh I updated twisted separately as suggested. Major bump, so that makes sense. For simplejson, I went through the changelog and I don't see how any of the changes could break existing applications. They are either new API additions or bugfixes to edge-cases. Is it really okay to create a new package for a minor version bump ? I also rebased branch on current master, the ids changed again. |
@roblabla |
I get an error running nox-review (both commands) : https://gist.github.com/10f9638a07d367b1f3a0 |
The travis error is related to pypy that is unable to compile, right? |
c181792
to
7e10bf4
Compare
Seems like blist doesn't support pypy : DanielStutzbach/blist#68 I added |
matrix-synapse: init at 0.12.0
Built locally, thanks. |
Adds matrix.org's synapse server as a package and module.
I am currently using this package on my server without any problems.