New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bluez: Disable kernel-dependent test test-mesh-crypto #123011
Merged
SuperSandro2000
merged 1 commit into
NixOS:staging
from
knedlsepp:bluez-kernel-dependent-test
Jul 7, 2021
Merged
bluez: Disable kernel-dependent test test-mesh-crypto #123011
SuperSandro2000
merged 1 commit into
NixOS:staging
from
knedlsepp:bluez-kernel-dependent-test
Jul 7, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knedlsepp
changed the title
bluez: Disable kernel dependent test-mesh-crypto
bluez: Disable kernel-dependent test-mesh-crypto
May 14, 2021
knedlsepp
changed the title
bluez: Disable kernel-dependent test-mesh-crypto
bluez: Disable kernel-dependent test test-mesh-crypto
May 14, 2021
knedlsepp
requested review from
FRidh,
jonringer,
Mic92,
WilliButz,
zowoq and
a team
as code owners
May 14, 2021 17:25
knedlsepp
force-pushed
the
bluez-kernel-dependent-test
branch
from
May 14, 2021 17:28
59140da
to
3b1da76
Compare
knedlsepp
requested review from
SuperSandro2000
and removed request for
jonringer,
WilliButz and
zowoq
May 14, 2021 17:28
ofborg
bot
added
10.rebuild-linux: 501-1000
and removed
10.rebuild-linux: 1001-2500
labels
May 14, 2021
Mic92
reviewed
May 15, 2021
Mic92
reviewed
May 15, 2021
I'm having trouble building bluez on a CentOS 7.9 builder. Turns out that the test-mesh-crypto test depends on the following Linux kernel configuration items: CONFIG_CRYPTO_[USER|USER_API|USER_API_AEAD|USER_API_HASH|AES|CCM|AEAD|CMAC] and will fail if run wih an incompatible kernel with the following error message: ... IVindex = 12345678 NetworkNonce = 00800000011201000012345678 00800000011201000012345678 => PASS PrivacyRandom = 000000000012345678b5e5bfdacbaf6c 000000000012345678fffd034b50057e => FAIL FAIL unit/test-mesh-crypto (exit status: 1) I found the same bug reported on Gentoo https://bugs.gentoo.org/704190. Their fix is to only run the test if the kernel options are available, which we don't want to do for build reproducibility. Instead we just want to skip the test unconditionally. As it's simpler to completely override the test instead of patching the build system, we opt for doing just that.
knedlsepp
force-pushed
the
bluez-kernel-dependent-test
branch
from
May 15, 2021 06:22
7618e79
to
05c5176
Compare
@Mic92 Mind taking another look? |
@ofborg eval |
friendly ping @SuperSandro2000 Can I provide something to make this happen? |
10 tasks
1 task
Successfully created backport PR #136490 for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
I'm having trouble building bluez on a CentOS 7.9 builder.
Turns out that the test-mesh-crypto test depends on the following Linux
kernel configuration items:
CONFIG_CRYPTO_[USER|USER_API|USER_API_AEAD|USER_API_HASH|AES|CCM|AEAD|CMAC]
and will fail if run wih an incompatible kernel with the following error
message:
I found the same bug reported on Gentoo https://bugs.gentoo.org/704190.
Their fix is to only run the test if the kernel options are available,
which we don't want to do for build reproducibility.
Instead we just want to skip the test unconditionally. As it's simpler
to completely override the test instead of patching the build system, we
opt for doing just that.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)