Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bluez: Disable kernel-dependent test test-mesh-crypto #123011

Merged

Conversation

knedlsepp
Copy link
Member

@knedlsepp knedlsepp commented May 14, 2021

Motivation for this change

I'm having trouble building bluez on a CentOS 7.9 builder.
Turns out that the test-mesh-crypto test depends on the following Linux
kernel configuration items:
CONFIG_CRYPTO_[USER|USER_API|USER_API_AEAD|USER_API_HASH|AES|CCM|AEAD|CMAC]
and will fail if run wih an incompatible kernel with the following error
message:

...
IVindex              = 12345678
NetworkNonce         = 00800000011201000012345678
                       00800000011201000012345678 => PASS
PrivacyRandom        = 000000000012345678b5e5bfdacbaf6c
                       000000000012345678fffd034b50057e => FAIL
FAIL unit/test-mesh-crypto (exit status: 1)

I found the same bug reported on Gentoo https://bugs.gentoo.org/704190.
Their fix is to only run the test if the kernel options are available,
which we don't want to do for build reproducibility.
Instead we just want to skip the test unconditionally. As it's simpler
to completely override the test instead of patching the build system, we
opt for doing just that.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@knedlsepp knedlsepp requested review from SuperSandro2000 and removed request for jonringer, WilliButz and zowoq May 14, 2021 17:28
@veprbl veprbl added this to WIP in Staging via automation May 14, 2021
@veprbl veprbl moved this from WIP to Needs review in Staging May 14, 2021
I'm having trouble building bluez on a CentOS 7.9 builder.
Turns out that the test-mesh-crypto test depends on the following Linux
kernel configuration items:
CONFIG_CRYPTO_[USER|USER_API|USER_API_AEAD|USER_API_HASH|AES|CCM|AEAD|CMAC]
and will fail if run wih an incompatible kernel with the following error
message:

    ...
    IVindex              = 12345678
    NetworkNonce         = 00800000011201000012345678
                           00800000011201000012345678 => PASS
    PrivacyRandom        = 000000000012345678b5e5bfdacbaf6c
                           000000000012345678fffd034b50057e => FAIL
    FAIL unit/test-mesh-crypto (exit status: 1)

I found the same bug reported on Gentoo https://bugs.gentoo.org/704190.
Their fix is to only run the test if the kernel options are available,
which we don't want to do for build reproducibility.
Instead we just want to skip the test unconditionally. As it's simpler
to completely override the test instead of patching the build system, we
opt for doing just that.
@knedlsepp knedlsepp force-pushed the bluez-kernel-dependent-test branch from 7618e79 to 05c5176 Compare May 15, 2021 06:22
@knedlsepp
Copy link
Member Author

@Mic92 Mind taking another look?

@SuperSandro2000
Copy link
Member

@ofborg eval

@knedlsepp
Copy link
Member Author

friendly ping @SuperSandro2000 Can I provide something to make this happen?

@SuperSandro2000 SuperSandro2000 merged commit e1f193a into NixOS:staging Jul 7, 2021
Staging automation moved this from Needs review to Done Jul 7, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2021

Successfully created backport PR #136490 for staging-21.05.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Staging
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants