Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cairomm_1_16: fix darwin build #123020

Merged
merged 1 commit into from May 15, 2021
Merged

Conversation

stephank
Copy link
Contributor

Motivation for this change

ZHF: #122042
cc @NixOS/nixos-release-managers

Hydra failure: https://hydra.nixos.org/build/142578519/nixlog/1

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label May 14, 2021
@ofborg ofborg bot requested review from hedning, jtojnar, amaxine and dasj19 May 14, 2021 19:46
@ofborg ofborg bot requested a review from jtojnar May 14, 2021 20:23
@rmcgibbo
Copy link
Contributor

Result of nixpkgs-review pr 123020 run on x86_64-darwin 1

3 packages failed to build:
  • cairomm_1_16
  • gtkmm4
  • pangomm_2_48

end of the log: https://gist.github.com/rmcgibbo/5f534f91b91fab01abff03da7ee58dd4

@stephank
Copy link
Contributor Author

Hmm, could this be related to the darwin sandbox? My local build was without sandboxing.

If so, is it crude if we just disable tests on darwin?

@veprbl
Copy link
Member

veprbl commented May 14, 2021

Hmm, could this be related to the darwin sandbox? My local build was without sandboxing.

If so, is it crude if we just disable tests on darwin?

It looks like sandboxing related to me as well. There is no policy for this that I know of (but it would be nice if someone could file an issue to start the discussion). If it builds without sandbox, I would not disable tests and leave it with a broken sandboxed build for now.

@stephank
Copy link
Contributor Author

Leaving stuff broken on Hydra feels a bit wrong, though. It inhibits efforts like ZHF.

@veprbl
Copy link
Member

veprbl commented May 15, 2021

Leaving stuff broken on Hydra feels a bit wrong, though. It inhibits efforts like ZHF.

Hydra doesn't enable sandboxing. If you want to disable tests please leave a comment that this is a due to sandboxing, so that we can revisit this later.

@stephank
Copy link
Contributor Author

Alright, I pushed a commit that disables tests on Darwin only, with a comment.

@veprbl
Copy link
Member

veprbl commented May 15, 2021

Result of nixpkgs-review pr 123020 run on x86_64-darwin 1

1 package failed to build:
  • gtkmm4
2 packages built:
  • cairomm_1_16
  • pangomm_2_48

@veprbl veprbl merged commit f8a8ac2 into NixOS:master May 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants