New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cairomm_1_16: fix darwin build #123020
cairomm_1_16: fix darwin build #123020
Conversation
Result of 3 packages failed to build:
end of the log: https://gist.github.com/rmcgibbo/5f534f91b91fab01abff03da7ee58dd4 |
Hmm, could this be related to the darwin sandbox? My local build was without sandboxing. If so, is it crude if we just disable tests on darwin? |
It looks like sandboxing related to me as well. There is no policy for this that I know of (but it would be nice if someone could file an issue to start the discussion). If it builds without sandbox, I would not disable tests and leave it with a broken sandboxed build for now. |
Leaving stuff broken on Hydra feels a bit wrong, though. It inhibits efforts like ZHF. |
Hydra doesn't enable sandboxing. If you want to disable tests please leave a comment that this is a due to sandboxing, so that we can revisit this later. |
2a89e77
to
e4b1609
Compare
e4b1609
to
0d70085
Compare
Alright, I pushed a commit that disables tests on Darwin only, with a comment. |
Result of 1 package failed to build:
2 packages built:
|
Motivation for this change
ZHF: #122042
cc @NixOS/nixos-release-managers
Hydra failure: https://hydra.nixos.org/build/142578519/nixlog/1
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)