Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cd-hit: fix darwin build #123026

Merged
merged 2 commits into from May 14, 2021
Merged

cd-hit: fix darwin build #123026

merged 2 commits into from May 14, 2021

Conversation

stephank
Copy link
Contributor

Motivation for this change

ZHF: #122042
cc @NixOS/nixos-release-managers

Hydra failure: https://hydra.nixos.org/build/142598941/log

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@r-rmcgibbo
Copy link

r-rmcgibbo commented May 14, 2021

Result of nixpkgs-review pr 123026 at 4055fa2 run on aarch64-linux 1

1 package built successfully:
  • cd-hit
1 suggestion:
  • warning: unclear-gpl

    gpl2 is a deprecated license, please check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.

    Near pkgs/applications/science/biology/cd-hit/default.nix:34:5:

       |
    34 |     license = licenses.gpl2;
       |     ^
    

Result of nixpkgs-review pr 123026 at 4055fa2 run on x86_64-linux 1

1 package built successfully:
  • cd-hit
1 suggestion:
  • warning: unclear-gpl

    gpl2 is a deprecated license, please check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.

    Near pkgs/applications/science/biology/cd-hit/default.nix:34:5:

       |
    34 |     license = licenses.gpl2;
       |     ^
    

@veprbl
Copy link
Member

veprbl commented May 14, 2021

Upstream PR weizhongli/cdhit#114

@veprbl
Copy link
Member

veprbl commented May 14, 2021

Result of nixpkgs-review pr 123026 run on x86_64-darwin 1

1 package built:
  • cd-hit

@veprbl veprbl merged commit 2adca7a into NixOS:master May 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants