Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

llvmPackages_*.lldClang: pass -lunwind if exceptions are enabled #123047

Merged
merged 1 commit into from May 14, 2021
Merged

llvmPackages_*.lldClang: pass -lunwind if exceptions are enabled #123047

merged 1 commit into from May 14, 2021

Conversation

sternenseemann
Copy link
Member

@sternenseemann sternenseemann commented May 14, 2021 •
edited

To successfully compile C++ with useLLVM we need an unwinder and
thus to explicitly -lunwind like it has been done for the android
cross targets.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@sternenseemann
Copy link
Member Author 

nix-build -A pkgsLLVM.ncurses -A pkgsLLVM.abseil-cpp
/nix/store/dchgh8ql5zx30w80zwynl070lj52wgd9-ncurses-6.2-x86_64-unknown-linux-gnu
/nix/store/656fgp87vyv7nvmk7ng11iw78qlgwya8-abseil-cpp-x86_64-unknown-linux-gnu-20200923.3

@sternenseemann
llvmPackages_*.lldClang: pass -lunwind if exceptions are enabled
f506019 
To successfully compile C++ with useLLVM we need an unwinder and
thus to explicitly -lunwind like it has been done for the android
cross targets.
@Ericson2314 Ericson2314 merged commit 93e6a25 into NixOS:staging May 14, 2021
@sternenseemann sternenseemann deleted the usellvm-lunwind branch May 14, 2021 22:52
@sternenseemann sternenseemann restored the usellvm-lunwind branch July 24, 2021 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sternenseemann @Ericson2314