Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trouble.nvim: lsp-trouble.nvim -> trouble.nvim #123058

Merged
merged 2 commits into from May 15, 2021

Conversation

devins2518
Copy link
Contributor

Motivation for this change

pkgs/misc/vim-plugins/update.py currently fails because of a 404 trying to reach https://github.com/folke/lsp-trouble.nvim. This plugin as of 0f58468 was change to https://github.com/folke/trouble.nvim.

Things done

Changed folke/lsp-trouble.nvim@main to folke/trouble.nvim@main and updated plugins using maintainers/scripts/update.py

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@moni-dz

This comment has been minimized.

@r-rmcgibbo
Copy link

r-rmcgibbo commented May 15, 2021

Result of nixpkgs-review pr 123058 at b3f8a6d run on x86_64-linux 1

1 package failed to build:
40 packages built successfully:
  • spacevim
  • vimPlugins.auto-session
  • vimPlugins.barbar-nvim
  • vimPlugins.chadtree
  • vimPlugins.coc-nvim
  • vimPlugins.context_filetype-vim
  • vimPlugins.denite-nvim
  • vimPlugins.deoplete-fish
  • vimPlugins.deoplete-khard
  • vimPlugins.deoplete-nvim
  • vimPlugins.friendly-snippets
  • vimPlugins.git-messenger-vim
  • vimPlugins.git-worktree-nvim
  • vimPlugins.gitsigns-nvim
  • vimPlugins.lualine-nvim
  • vimPlugins.nvim-base16
  • vimPlugins.nvim-bqf
  • vimPlugins.nvim-bufferline-lua
  • vimPlugins.nvim-hlslens
  • vimPlugins.nvim-lspconfig
  • vimPlugins.nvim-toggleterm-lua
  • vimPlugins.nvim-treesitter-context
  • vimPlugins.nvim-ts-rainbow
  • vimPlugins.packer-nvim
  • vimPlugins.telescope-frecency-nvim
  • vimPlugins.telescope-fzf-writer-nvim
  • vimPlugins.telescope-fzy-native-nvim
  • vimPlugins.telescope-nvim
  • vimPlugins.telescope-symbols-nvim
  • vimPlugins.telescope-z-nvim
  • vimPlugins.trouble-nvim
  • vimPlugins.vim-dadbod
  • vimPlugins.vim-devicons
  • vimPlugins.vim-fireplace
  • vimPlugins.vim-fugitive
  • vimPlugins.vim-go
  • vimPlugins.vim-oscyank
  • vimPlugins.vim-visual-multi
  • vimPlugins.vimtex
  • vimPlugins.which-key-nvim
2 suggestions:
  • warning: missing-phase-hooks

    configurePhase should probably contain runHook preConfigure and runHook postConfigure.

    Near pkgs/misc/vim-plugins/build-vim-plugin.nix:28:14:

       |
    28 |       inherit unpackPhase configurePhase buildPhase addonInfo preInstall postInstall;
       |              ^
    
  • warning: missing-phase-hooks

    buildPhase should probably contain runHook preBuild and runHook postBuild.

    Near pkgs/misc/vim-plugins/build-vim-plugin.nix:28:14:

       |
    28 |       inherit unpackPhase configurePhase buildPhase addonInfo preInstall postInstall;
       |              ^
    

Note that build failures may predate this PR, and could be nondeterministic or hardware dependent.
Please exercise your independent judgement. Does something look off? Please file an issue or reach out on IRC.


Result of nixpkgs-review pr 123058 at b3f8a6d run on aarch64-linux 1

1 package failed to build:
2 packages built successfully:
  • spacevim
  • vimPlugins.telescope-fzy-native-nvim
2 suggestions:
  • warning: missing-phase-hooks

    configurePhase should probably contain runHook preConfigure and runHook postConfigure.

    Near pkgs/misc/vim-plugins/build-vim-plugin.nix:28:14:

       |
    28 |       inherit unpackPhase configurePhase buildPhase addonInfo preInstall postInstall;
       |              ^
    
  • warning: missing-phase-hooks

    buildPhase should probably contain runHook preBuild and runHook postBuild.

    Near pkgs/misc/vim-plugins/build-vim-plugin.nix:28:14:

       |
    28 |       inherit unpackPhase configurePhase buildPhase addonInfo preInstall postInstall;
       |              ^
    

Note that build failures may predate this PR, and could be nondeterministic or hardware dependent.
Please exercise your independent judgement. Does something look off? Please file an issue or reach out on IRC.

@moni-dz
Copy link
Contributor

moni-dz commented May 15, 2021

@ofborg build vimPlugins.vim-clap

@moni-dz
Copy link
Contributor

moni-dz commented May 15, 2021

Result of nixpkgs-review pr 123058 run on x86_64-linux 1

41 packages built:
  • spacevim
  • vimPlugins.auto-session
  • vimPlugins.barbar-nvim
  • vimPlugins.chadtree
  • vimPlugins.coc-nvim
  • vimPlugins.context-filetype (vimPlugins.context_filetype-vim)
  • vimPlugins.denite (vimPlugins.denite-nvim)
  • vimPlugins.deoplete-fish
  • vimPlugins.deoplete-khard
  • vimPlugins.deoplete-nvim
  • vimPlugins.friendly-snippets
  • vimPlugins.fugitive (vimPlugins.vim-fugitive)
  • vimPlugins.git-messenger-vim
  • vimPlugins.git-worktree-nvim
  • vimPlugins.gitsigns-nvim
  • vimPlugins.lualine-nvim
  • vimPlugins.nvim-base16
  • vimPlugins.nvim-bqf
  • vimPlugins.nvim-bufferline-lua
  • vimPlugins.nvim-hlslens
  • vimPlugins.nvim-lspconfig
  • vimPlugins.nvim-toggleterm-lua
  • vimPlugins.nvim-treesitter-context
  • vimPlugins.nvim-ts-rainbow
  • vimPlugins.packer-nvim
  • vimPlugins.telescope-frecency-nvim
  • vimPlugins.telescope-fzf-writer-nvim
  • vimPlugins.telescope-fzy-native-nvim
  • vimPlugins.telescope-nvim
  • vimPlugins.telescope-symbols-nvim
  • vimPlugins.telescope-z-nvim
  • vimPlugins.trouble-nvim
  • vimPlugins.vim-clap
  • vimPlugins.vim-dadbod
  • vimPlugins.vim-devicons
  • vimPlugins.vim-fireplace
  • vimPlugins.vim-go
  • vimPlugins.vim-oscyank
  • vimPlugins.vim-visual-multi
  • vimPlugins.vimtex
  • vimPlugins.which-key-nvim

@teto teto merged commit 5d176f3 into NixOS:master May 15, 2021
@devins2518 devins2518 deleted the fix-lsp-trouble branch January 17, 2022 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants