nodePackages.wavedrom-cli: init at 2.6.9 #123065

expipiplus1 · 2021-05-15T06:00:39Z

Also update nodePackages

r-rmcgibbo · 2021-05-15T06:27:00Z

Result of nixpkgs-review pr 123065 at c4e2c673 run on aarch64-linux 1

7 packages failed to build:

2 packages skipped due to time constraints:

iosevka
lumo

15 packages built successfully:

bat-extras.prettybat
discourse
mx-puppet-discord
parity-ui
python38Packages.batchspawner
python38Packages.dockerspawner
python38Packages.jupyterhub
python38Packages.jupyterhub-ldapauthenticator
python38Packages.jupyterhub-systemdspawner
python38Packages.jupyterhub-tmpauthenticator
python38Packages.oauthenticator
teleprompter
vscode-extensions.matklad.rust-analyzer
vscode-extensions.vadimcn.vscode-lldb
zerobin

Note that build failures may predate this PR, and could be nondeterministic or hardware dependent.
Please exercise your independent judgement. Does something look off? Please file an issue or reach out on IRC.

Result of nixpkgs-review pr 123065 at c4e2c673 run on x86_64-linux 1

8 packages failed to build:

2 packages skipped due to time constraints:

iosevka
lumo

55 packages built successfully:

antora
balanceofsatoshis
bat-extras.prettybat
bitwarden-cli
castnow
create-cycle-app
discourse
epgstation
fast-cli
flood
gtop
hueadm
joplin
mastodon-bot
mirakurun
mx-puppet-discord
n8n
parity-ui
pm2
postcss-cli
pscid
pulp
pyright
python39Packages.batchspawner
python39Packages.dockerspawner
python39Packages.jupyterhub
python39Packages.jupyterhub-ldapauthenticator
python39Packages.jupyterhub-systemdspawner
python39Packages.jupyterhub-tmpauthenticator
python39Packages.oauthenticator
redoc-cli
slack
teck-programmer
teleprompter
thelounge
vimPlugins.coc-diagnostic
vimPlugins.coc-explorer
vimPlugins.coc-git
vimPlugins.coc-highlight
vimPlugins.coc-lists
vimPlugins.coc-metals
vimPlugins.coc-prettier
vimPlugins.coc-pyright
vimPlugins.coc-rust-analyzer
vimPlugins.coc-snippets
vimPlugins.coc-stylelint
vimPlugins.coc-tabnine
vimPlugins.coc-tslint
vimPlugins.coc-vetur
vscode-extensions.matklad.rust-analyzer
vscode-extensions.ms-python.vscode-pylance
vscode-extensions.vadimcn.vscode-lldb
wasm-text-gen
yaml-language-server
zerobin

57 suggestions:

warning: unused-argument

Unused argument: nix-gitignore.
Near pkgs/development/node-packages/node-packages.nix:3:31:

  |
3 | {nodeEnv, fetchurl, fetchgit, nix-gitignore, stdenv, lib, globalBuildInputs ? []}:
  |                               ^

warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?

Near pkgs/development/node-packages/node-packages.nix:100653:5:
```
       |
100653 |     meta = {
       |     ^
```
warning: missing-phase-hooks
buildPhase should probably contain runHook preBuild and runHook postBuild.

Near pkgs/development/node-packages/node-env.nix:409:14:
```
    |
409 |       inherit dontNpmInstall preRebuild unpackPhase buildPhase;
    |              ^
```
warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?

Near pkgs/development/node-packages/node-packages.nix:93455:5:
```
      |
93455 |     meta = {
      |     ^
```
warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?

Near pkgs/development/node-packages/node-packages.nix:117340:5:
```
       |
117340 |     meta = {
       |     ^
```
warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?

Near pkgs/development/node-packages/node-packages.nix:100708:5:
```
       |
100708 |     meta = {
       |     ^
```
warning: build-tools-in-build-inputs
nodePackages.node-pre-gyp is a build tool so it likely goes to nativeBuildInputs, not buildInputs.

Near pkgs/development/node-packages/node-env.nix:401:7:
```
    |
401 |       buildInputs = [ tarWrapper python nodejs ]
    |       ^
```
warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?

Near pkgs/development/node-packages/node-packages.nix:101057:5:
```
       |
101057 |     meta = {
       |     ^
```
warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?

Near pkgs/development/node-packages/default.nix:65:7:
```
   |
65 |       meta.mainProgram = "bw";
   |       ^
```
warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?

Near pkgs/development/node-packages/node-packages.nix:73660:5:
```
      |
73660 |     meta = {
      |     ^
```
warning: name-and-version
Did you mean to pass pname instead of name to mkDerivation?

Near pkgs/development/node-packages/node-env.nix:400:7:
```
    |
400 |       name = "node_${name}-${version}";
    |       ^
```
Near pkgs/development/node-packages/node-packages.nix:117302:5:
```
       |
117302 |     version = "0.19.0";
       |     ^
```
warning: name-and-version
Did you mean to pass pname instead of name to mkDerivation?

Near pkgs/development/node-packages/node-env.nix:400:7:
```
    |
400 |       name = "node_${name}-${version}";
    |       ^
```
Near pkgs/development/node-packages/node-packages.nix:80319:5:
```
      |
80319 |     version = "1.0.0";
      |     ^
```
warning: license-missing
Package is missing a license.

Near pkgs/development/node-packages/default.nix:65:7:
```
   |
65 |       meta.mainProgram = "bw";
   |       ^
```
warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?

Near pkgs/development/node-packages/node-packages.nix:100487:5:
```
       |
100487 |     meta = {
       |     ^
```
warning: missing-phase-hooks
configurePhase should probably contain runHook preConfigure and runHook postConfigure.

Near pkgs/misc/vim-plugins/build-vim-plugin.nix:28:14:
```
   |
28 |       inherit unpackPhase configurePhase buildPhase addonInfo preInstall postInstall;
   |              ^
```
warning: name-and-version
Did you mean to pass pname instead of name to mkDerivation?

Near pkgs/development/node-packages/node-env.nix:400:7:
```
    |
400 |       name = "node_${name}-${version}";
    |       ^
```
Near pkgs/development/node-packages/node-packages.nix:111356:5:
```
       |
111356 |     version = "4.2.0";
       |     ^
```

warning: unused-argument

Unused argument: lib.
Near pkgs/development/node-packages/node-packages.nix:3:54:

  |
3 | {nodeEnv, fetchurl, fetchgit, nix-gitignore, stdenv, lib, globalBuildInputs ? []}:
  |                                                      ^

warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?

Near pkgs/development/node-packages/node-packages.nix:82424:5:
```
      |
82424 |     meta = {
      |     ^
```
warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?

Near pkgs/development/node-packages/node-packages.nix:100973:5:
```
       |
100973 |     meta = {
       |     ^
```
warning: name-and-version
Did you mean to pass pname instead of name to mkDerivation?

Near pkgs/development/node-packages/node-env.nix:400:7:
```
    |
400 |       name = "node_${name}-${version}";
    |       ^
```
Near pkgs/development/node-packages/node-packages.nix:64820:5:
```
      |
64820 |     version = "1.16.0";
      |     ^
```
warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?

Near pkgs/development/node-packages/node-packages.nix:64492:5:
```
      |
64492 |     meta = {
      |     ^
```
warning: name-and-version
Did you mean to pass pname instead of name to mkDerivation?

Near pkgs/development/node-packages/node-env.nix:400:7:
```
    |
400 |       name = "node_${name}-${version}";
    |       ^
```
Near pkgs/development/node-packages/node-packages.nix:64467:5:
```
      |
64467 |     version = "2.3.4";
      |     ^
```
warning: build-tools-in-build-inputs
util-linux is a build tool so it likely goes to nativeBuildInputs, not buildInputs.

Near pkgs/development/node-packages/node-env.nix:401:7:
```
    |
401 |       buildInputs = [ tarWrapper python nodejs ]
    |       ^
```
warning: name-and-version
Did you mean to pass pname instead of name to mkDerivation?

Near pkgs/development/node-packages/node-env.nix:400:7:
```
    |
400 |       name = "node_${name}-${version}";
    |       ^
```
Near pkgs/development/node-packages/node-packages.nix:82418:5:
```
      |
82418 |     version = "4.5.4";
      |     ^
```
warning: name-and-version
Did you mean to pass pname instead of name to mkDerivation?

Near pkgs/development/node-packages/node-env.nix:400:7:
```
    |
400 |       name = "node_${name}-${version}";
    |       ^
```
Near pkgs/development/node-packages/node-packages.nix:86284:5:
```
      |
86284 |     version = "1.2.0";
      |     ^
```
warning: name-and-version
Did you mean to pass pname instead of name to mkDerivation?

Near pkgs/development/node-packages/node-env.nix:400:7:
```
    |
400 |       name = "node_${name}-${version}";
    |       ^
```
Near pkgs/development/node-packages/node-packages.nix:93720:5:
```
      |
93720 |     version = "3.29.15";
      |     ^
```
warning: build-tools-in-build-inputs
nodePackages.node-gyp-build is a build tool so it likely goes to nativeBuildInputs, not buildInputs.

Near pkgs/development/node-packages/node-env.nix:401:7:
```
    |
401 |       buildInputs = [ tarWrapper python nodejs ]
    |       ^
```
warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?

Near pkgs/development/node-packages/node-packages.nix:67806:5:
```
      |
67806 |     meta = {
      |     ^
```
warning: name-and-version
Did you mean to pass pname instead of name to mkDerivation?

Near pkgs/development/node-packages/node-env.nix:400:7:
```
    |
400 |       name = "node_${name}-${version}";
    |       ^
```
Near pkgs/development/node-packages/node-packages.nix:101051:5:
```
       |
101051 |     version = "1.1.139";
       |     ^
```
warning: name-and-version
Did you mean to pass pname instead of name to mkDerivation?

Near pkgs/development/node-packages/node-env.nix:400:7:
```
    |
400 |       name = "node_${name}-${version}";
    |       ^
```
Near pkgs/development/node-packages/node-packages.nix:68791:5:
```
      |
68791 |     version = "0.6.0";
      |     ^
```
warning: name-and-version
Did you mean to pass pname instead of name to mkDerivation?

Near pkgs/development/node-packages/node-env.nix:400:7:
```
    |
400 |       name = "node_${name}-${version}";
    |       ^
```
Near pkgs/development/node-packages/node-packages.nix:103342:5:
```
       |
103342 |     version = "0.11.4";
       |     ^
```
warning: name-and-version
Did you mean to pass pname instead of name to mkDerivation?

Near pkgs/development/node-packages/node-env.nix:400:7:
```
    |
400 |       name = "node_${name}-${version}";
    |       ^
```
Near pkgs/development/node-packages/node-packages.nix:66660:5:
```
      |
66660 |     version = "1.11.0";
      |     ^
```
warning: name-and-version
Did you mean to pass pname instead of name to mkDerivation?

Near pkgs/development/node-packages/node-env.nix:400:7:
```
    |
400 |       name = "node_${name}-${version}";
    |       ^
```
Near pkgs/development/node-packages/node-packages.nix:73505:5:
```
      |
73505 |     version = "5.0.0";
      |     ^
```
warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?

Near pkgs/development/node-packages/node-packages.nix:88169:5:
```
      |
88169 |     meta = {
      |     ^
```
warning: name-and-version
Did you mean to pass pname instead of name to mkDerivation?

Near pkgs/development/node-packages/node-env.nix:400:7:
```
    |
400 |       name = "node_${name}-${version}";
    |       ^
```
Near pkgs/development/node-packages/node-packages.nix:100545:5:
```
       |
100545 |     version = "8.3.1";
       |     ^
```
warning: name-and-version
Did you mean to pass pname instead of name to mkDerivation?

Near pkgs/development/node-packages/node-env.nix:400:7:
```
    |
400 |       name = "node_${name}-${version}";
    |       ^
```
Near pkgs/development/node-packages/node-packages.nix:67123:5:
```
      |
67123 |     version = "8.0.11";
      |     ^
```
warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?

Near pkgs/development/node-packages/node-packages.nix:95705:5:
```
      |
95705 |     meta = {
      |     ^
```
warning: name-and-version
Did you mean to pass pname instead of name to mkDerivation?

Near pkgs/development/node-packages/node-env.nix:400:7:
```
    |
400 |       name = "node_${name}-${version}";
    |       ^
```
Near pkgs/development/node-packages/node-packages.nix:93195:5:
```
      |
93195 |     version = "3.5.0";
      |     ^
```
warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?

Near pkgs/development/node-packages/node-packages.nix:110205:5:
```
       |
110205 |     meta = {
       |     ^
```
warning: name-and-version
Did you mean to pass pname instead of name to mkDerivation?

Near pkgs/development/node-packages/node-env.nix:400:7:
```
    |
400 |       name = "node_${name}-${version}";
    |       ^
```
Near pkgs/development/node-packages/node-packages.nix:100683:5:
```
       |
100683 |     version = "2.9.3";
       |     ^
```
warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?

Near pkgs/development/node-packages/node-packages.nix:103694:5:
```
       |
103694 |     meta = {
       |     ^
```
warning: name-and-version
Did you mean to pass pname instead of name to mkDerivation?

Near pkgs/development/node-packages/node-env.nix:400:7:
```
    |
400 |       name = "node_${name}-${version}";
    |       ^
```
Near pkgs/development/node-packages/node-packages.nix:100720:5:
```
       |
100720 |     version = "15.0.0";
       |     ^
```
warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?

Near pkgs/development/node-packages/node-packages.nix:111791:5:
```
       |
111791 |     meta = {
       |     ^
```
warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?

Near pkgs/development/node-packages/node-packages.nix:85132:5:
```
      |
85132 |     meta = {
      |     ^
```
warning: name-and-version
Did you mean to pass pname instead of name to mkDerivation?

Near pkgs/development/node-packages/node-env.nix:400:7:
```
    |
400 |       name = "node_${name}-${version}";
    |       ^
```
Near pkgs/development/node-packages/node-packages.nix:87440:5:
```
      |
87440 |     version = "1.8.1";
      |     ^
```

warning: unused-argument

Unused argument: stdenv.
Near pkgs/development/node-packages/node-packages.nix:3:46:

  |
3 | {nodeEnv, fetchurl, fetchgit, nix-gitignore, stdenv, lib, globalBuildInputs ? []}:
  |                                              ^

warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?

Near pkgs/development/node-packages/node-packages.nix:80492:5:
```
      |
80492 |     meta = {
      |     ^
```
warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?

Near pkgs/development/node-packages/node-packages.nix:86328:5:
```
      |
86328 |     meta = {
      |     ^
```
warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?

Near pkgs/development/node-packages/node-packages.nix:66698:5:
```
      |
66698 |     meta = {
      |     ^
```
warning: name-and-version
Did you mean to pass pname instead of name to mkDerivation?

Near pkgs/development/node-packages/node-env.nix:400:7:
```
    |
400 |       name = "node_${name}-${version}";
    |       ^
```
Near pkgs/development/node-packages/node-packages.nix:92689:5:
```
      |
92689 |     version = "1.10.12-20210326145549";
      |     ^
```
warning: name-and-version
Did you mean to pass pname instead of name to mkDerivation?

Near pkgs/development/node-packages/node-env.nix:400:7:
```
    |
400 |       name = "node_${name}-${version}";
    |       ^
```
Near pkgs/development/node-packages/node-packages.nix:110127:5:
```
       |
110127 |     version = "1.1.1";
       |     ^
```
warning: name-and-version
Did you mean to pass pname instead of name to mkDerivation?

Near pkgs/development/node-packages/node-env.nix:400:7:
```
    |
400 |       name = "node_${name}-${version}";
    |       ^
```
Near pkgs/development/node-packages/node-packages.nix:100271:5:
```
       |
100271 |     version = "4.5.6";
       |     ^
```
warning: missing-phase-hooks
installPhase should probably contain runHook preInstall.

Near pkgs/development/node-packages/node-env.nix:416:7:
```
    |
416 |       installPhase = ''
    |       ^
```
warning: name-and-version
Did you mean to pass pname instead of name to mkDerivation?

Near pkgs/development/node-packages/node-env.nix:400:7:
```
    |
400 |       name = "node_${name}-${version}";
    |       ^
```
Near pkgs/development/node-packages/node-packages.nix:85054:5:
```
      |
85054 |     version = "1.1.0";
      |     ^
```
warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?

Near pkgs/development/node-packages/node-packages.nix:92972:5:
```
      |
92972 |     meta = {
      |     ^
```
warning: missing-phase-hooks
buildPhase should probably contain runHook preBuild and runHook postBuild.

Near pkgs/misc/vim-plugins/build-vim-plugin.nix:28:14:
```
   |
28 |       inherit unpackPhase configurePhase buildPhase addonInfo preInstall postInstall;
   |              ^
```
warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?

Near pkgs/development/node-packages/node-packages.nix:69202:5:
```
      |
69202 |     meta = {
      |     ^
```

Note that build failures may predate this PR, and could be nondeterministic or hardware dependent.
Please exercise your independent judgement. Does something look off? Please file an issue or reach out on IRC.

expipiplus1 · 2021-05-16T02:41:54Z

Does anyone with more nix node knowledge know what do do about that failure?

midchildan · 2021-05-26T16:14:51Z

@expipiplus1 They all seem to be unrelated failures. The netlify-cli failure appears to be caused by #122498, but that should probably be addressed in another PR.

midchildan · 2021-05-26T16:35:13Z

The Darwin build for this package is failing because node-gyp is attempting to check for the existence of the XCode Command Line Tools. Nixpkgs seems to have a patch for this, but it's no longer working as intended.

This can probably go to another PR too.

Related: #102973

pkgs/development/node-packages/default.nix

expipiplus1 · 2021-05-27T07:06:12Z

The Darwin build for this package is failing because node-gyp is attempting to check for the existence of the XCode Command Line Tools. Nixpkgs seems to have a patch for this, but it's no longer working as intended.

Probably not appropriate to mark this as Linux only though.

@expipiplus1 They all seem to be unrelated failures.

Great!

I've added the requested comment and rebased. Thanks for the review, @midchildan

midchildan · 2021-05-29T10:41:04Z

Change looks good. It needs a rebase and a re-run of ./generate.sh to fix the merge conflict.

Also update nodePackages

expipiplus1 · 2021-06-02T02:36:21Z

Change looks good. It needs a rebase and a re-run of ./generate.sh to fix the merge conflict.

done, thanks!

expipiplus1 · 2021-06-04T01:02:45Z

thanks！

…

On Thu, 3 Jun 2021, 10:51 pm Sandro, ***@***.***> wrote: Merged #123065 <#123065> into master. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#123065 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAGRJXBOCJDIR77JXKCLSELTQ6H3RANCNFSM445RS5BQ> .

ofborg bot requested a review from midchildan May 15, 2021 06:09

ofborg bot added 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 labels May 15, 2021

midchildan suggested changes May 26, 2021

View reviewed changes

pkgs/development/node-packages/default.nix Show resolved Hide resolved

expipiplus1 force-pushed the joe-wavedrom-cli-2 branch from c4e2c67 to 4c384fd Compare May 27, 2021 07:04

ofborg bot requested a review from midchildan May 27, 2021 07:15

SuperSandro2000 added the 2.status: merge conflict label May 29, 2021

nodePackages.wavedrom-cli: init at 2.6.9

57af172

Also update nodePackages

expipiplus1 force-pushed the joe-wavedrom-cli-2 branch from 4c384fd to 57af172 Compare June 2, 2021 02:35

ofborg bot added 10.rebuild-darwin: 1-10 and removed 2.status: merge conflict 10.rebuild-darwin: 11-100 labels Jun 2, 2021

midchildan approved these changes Jun 2, 2021

View reviewed changes

SuperSandro2000 merged commit 64635ab into NixOS:master Jun 3, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

nodePackages.wavedrom-cli: init at 2.6.9 #123065

nodePackages.wavedrom-cli: init at 2.6.9 #123065

expipiplus1 commented May 15, 2021

r-rmcgibbo commented May 15, 2021 •

edited

expipiplus1 commented May 16, 2021

midchildan commented May 26, 2021

midchildan commented May 26, 2021

expipiplus1 commented May 27, 2021

midchildan commented May 29, 2021

expipiplus1 commented Jun 2, 2021

expipiplus1 commented Jun 4, 2021 via email

nodePackages.wavedrom-cli: init at 2.6.9 #123065

nodePackages.wavedrom-cli: init at 2.6.9 #123065

Conversation

expipiplus1 commented May 15, 2021

r-rmcgibbo commented May 15, 2021 • edited

expipiplus1 commented May 16, 2021

midchildan commented May 26, 2021

midchildan commented May 26, 2021

expipiplus1 commented May 27, 2021

midchildan commented May 29, 2021

expipiplus1 commented Jun 2, 2021

expipiplus1 commented Jun 4, 2021 via email

r-rmcgibbo commented May 15, 2021 •

edited