Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustc: 1_52, use correct llvm version #123074

Merged
merged 1 commit into from May 17, 2021
Merged

rustc: 1_52, use correct llvm version #123074

merged 1 commit into from May 17, 2021

Conversation

lblasc
Copy link
Contributor

@lblasc lblasc commented May 15, 2021 •
edited

Motivation for this change

rustc form rustup uses llvm12

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@lblasc lblasc requested review from LnL7, Mic92 and zowoq as code owners May 15, 2021 08:00
@lblasc
Copy link
Contributor Author

lblasc commented May 15, 2021

It would be great to see this merged before the start of next staging-next.

@lblasc lblasc requested a review from jonringer May 15, 2021 08:07
@lblasc
Copy link
Contributor Author

lblasc commented May 15, 2021

ofborg failure is not related to this changes, I've managed to successfully build and run fd (on x86_64).

@lblasc lblasc mentioned this pull request May 17, 2021
Closed
jonringer
jonringer approved these changes May 17, 2021
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

https://github.com/NixOS/nixpkgs/pull/123074

1 package built:
ripgrep

@jonringer jonringer merged commit ded9963 into NixOS:staging May 17, 2021
@jonringer jonringer added the 9.needs: port to stable A PR needs a backport to the stable release. label May 17, 2021
@lblasc lblasc deleted the rust-llvm branch May 17, 2021 15:44
@bachp bachp mentioned this pull request May 18, 2021
Merged
10 tasks
@lblasc lblasc mentioned this pull request May 23, 2021
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@LnL7 LnL7 Awaiting requested review from LnL7

@Mic92 Mic92 Awaiting requested review from Mic92 Mic92 is a code owner

@zowoq zowoq Awaiting requested review from zowoq zowoq is a code owner

Assignees
No one assigned
Labels
6.topic: rust 9.needs: port to stable A PR needs a backport to the stable release. 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lblasc @jonringer