Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hdhomerun-config-gui: 20200907 -> 20210224 #123078

Merged
merged 1 commit into from May 16, 2021

Conversation

LouisDK1
Copy link
Contributor

Motivation for this change

New release 20210224

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@r-rmcgibbo
Copy link

r-rmcgibbo commented May 15, 2021

Result of nixpkgs-review pr 123078 at 7425cf3 run on x86_64-linux 1

1 package built successfully:
  • hdhomerun-config-gui
1 suggestion:
  • warning: missing-phase-hooks

    installPhase should probably contain runHook preInstall and runHook postInstall.

    Near pkgs/applications/video/hdhomerun-config-gui/default.nix:18:3:

       |
    18 |   installPhase = ''
       |   ^
    

Result of nixpkgs-review pr 123078 at 7425cf3 run on aarch64-linux 1

1 package built successfully:
  • hdhomerun-config-gui

@teto teto merged commit 7a1fbc3 into NixOS:master May 16, 2021
@LouisDK1 LouisDK1 deleted the hdhomerun_20210224 branch May 16, 2021 21:18
@LouisDK1 LouisDK1 restored the hdhomerun_20210224 branch May 16, 2021 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants