Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hplipWithPlugin: correct arch name for the plugin file on aarch64 #123086

Merged
merged 1 commit into from May 17, 2021

Conversation

mebubo
Copy link
Contributor

@mebubo mebubo commented May 15, 2021

Motivation for this change

Without this change, building hplipWithPlugin on aarch64 fails with:

cp: cannot stat 'lj-aarch64.so': No such file or directory
builder for '/nix/store/p0x02ppv0n1xj46wvik3p3cn4jikmr1q-hplip-3.20.11.drv' failed with exit code 1

This is because the corresponding file in the archive is actually called
lj-arm64.so.

hplipPlatforms exists to convert between the different names; this
commit only changes the value to a correct one.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Without this change, building hplipWithPlugin on aarch64 fails with:

    cp: cannot stat 'lj-aarch64.so': No such file or directory
    builder for '/nix/store/p0x02ppv0n1xj46wvik3p3cn4jikmr1q-hplip-3.20.11.drv' failed with exit code 1

This is because the corresponding file in the archive is actually called
lj-arm64.so.

hplipPlatforms exists to convert between the different names; this
commit only changes the value to a correct one.
@r-rmcgibbo
Copy link

Result of nixpkgs-review pr 123086 at 5153e0e run on aarch64-linux 1

1 package built successfully:
  • hplipWithPlugin
1 suggestion:
  • warning: unused-argument

    Unused argument: coreutils.
    Near pkgs/misc/drivers/hplip/default.nix:6:9:

      |
    6 | , bash, coreutils, util-linux
      |         ^
    

@SuperSandro2000 SuperSandro2000 merged commit 11d75bc into NixOS:master May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants