Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

foma: fix darwin build #123100

Merged
merged 1 commit into from May 15, 2021
Merged

foma: fix darwin build #123100

merged 1 commit into from May 15, 2021

Conversation

stephank
Copy link
Contributor

Motivation for this change

ZHF: #122042
cc @NixOS/nixos-release-managers

Hydra failure: https://hydra.nixos.org/build/142001673/log

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label May 15, 2021
@ofborg ofborg bot requested a review from tckmn May 15, 2021 12:37
@r-rmcgibbo
Copy link

r-rmcgibbo commented May 15, 2021 •
edited

Result of nixpkgs-review pr 123100 at 3de0119 run on aarch64-linux 1

2 packages built successfully:
  • foma
  • haskellPackages.foma

Result of nixpkgs-review pr 123100 at 3de0119 run on x86_64-linux 1

2 packages built successfully:
  • foma
  • haskellPackages.foma
1 suggestion:
  • warning: patch-phase

    patchPhase should not be overridden, use postPatch instead.

    Near pkgs/tools/misc/foma/default.nix:24:3:

       |
24 |   patchPhase = ''
   |   ^

rmcgibbo
rmcgibbo approved these changes May 15, 2021
View reviewed changes
Copy link
Contributor

@rmcgibbo rmcgibbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nixpkgs-review pr 123100 run on x86_64-darwin 1

2 packages built:
  • foma
  • haskellPackages.foma

@bhipple bhipple merged commit 229aec3 into NixOS:master May 15, 2021
@stephank stephank deleted the fix-foma-darwin branch May 15, 2021 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmcgibbo rmcgibbo rmcgibbo approved these changes

@tckmn tckmn Awaiting requested review from tckmn

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@stephank @r-rmcgibbo @rmcgibbo @bhipple