Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

smartgithg: 19.1.1 -> 20.2.5 #123101

Merged
merged 1 commit into from May 17, 2021
Merged

smartgithg: 19.1.1 -> 20.2.5 #123101

merged 1 commit into from May 17, 2021

Conversation

romildo
Copy link
Contributor

@romildo romildo commented May 15, 2021

Motivation for this change

Update to version 20.2.5

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jraygauthier
Copy link
Member

@romildo: LGTM code-wise. Does it still run / work well?

@romildo
Copy link
Contributor Author

romildo commented May 17, 2021

@romildo: LGTM code-wise. Does it still run / work well?

Yes, it still runs. I have used it to look at the commit history of the nixpkgs repository. But I do not used it heavily.

@SuperSandro2000 SuperSandro2000 merged commit d1dbc93 into NixOS:master May 17, 2021
@romildo romildo deleted the upd.smartgithg branch May 17, 2021 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants