Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ssb-patchwork: 3.18.0 -> 3.18.1 #123112

Merged
merged 1 commit into from May 17, 2021
Merged

ssb-patchwork: 3.18.0 -> 3.18.1 #123112

merged 1 commit into from May 17, 2021

Conversation

cyplo
Copy link
Contributor

@cyplo cyplo commented May 15, 2021

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@cyplo cyplo closed this May 15, 2021
@cyplo cyplo reopened this May 15, 2021
@ofborg ofborg bot requested review from picnoir and asymmetric May 15, 2021 14:06
@asymmetric
Copy link
Contributor

Result of nixpkgs-review pr 123112 run on x86_64-linux 1

1 package built:
  • ssb-patchwork

asymmetric
asymmetric reviewed May 15, 2021
View reviewed changes
Copy link
Contributor

@asymmetric asymmetric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't currently test execution, since it's been erroring with RangeError: Maximum call stack size exceeded for a while (this is not related to this PR)

pkgs/applications/networking/ssb-patchwork/default.nix
@@ -47,7 +47,7 @@ in
'';
homepage = "https://www.scuttlebutt.nz/";
license = licenses.agpl3;
maintainers = with maintainers; [ asymmetric ninjatrappeur ];
maintainers = with maintainers; [ asymmetric ninjatrappeur cyplo ];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cyplo are you aware this is the last release there will ever be?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure tbh, it's latest as of now;

are you okay with me being added to maintainers here ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure tbh, it's latest as of now;

Here's the info: https://github.com/ssbc/patchwork/releases/tag/v3.18.1

are you okay with me being added to maintainers here ?

sure :)

@cyplo
Copy link
Contributor Author

cyplo commented May 15, 2021

I can't currently test execution, since it's been erroring with RangeError: Maximum call stack size exceeded for a while (this is not related to this PR)

I tried re-opening the PR to retry the build but it seems to have some unrelated error as you've mentioned

@asymmetric
Copy link
Contributor

I tried re-opening the PR to retry the build but it seems to have some unrelated error as you've mentioned

So it doesn't run properly for you either?

@cyplo
Copy link
Contributor Author

cyplo commented May 15, 2021

I tried re-opening the PR to retry the build but it seems to have some unrelated error as you've mentioned

So it doesn't run properly for you either?

locally everything is fine, but anything that touches the CI on github seems broken

@asymmetric
Copy link
Contributor

@ofborg eval
@ofborg build ssb-patchwork

@ofborg ofborg bot requested a review from asymmetric May 16, 2021 15:44
@SuperSandro2000 SuperSandro2000 merged commit 06d7fd6 into NixOS:master May 17, 2021
@cyplo cyplo deleted the upgrade-patchwork branch May 19, 2021 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@picnoir picnoir Awaiting requested review from picnoir

@asymmetric asymmetric Awaiting requested review from asymmetric

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cyplo @asymmetric @SuperSandro2000