vimPlugins.vim-easyescape: init at 2020-11-22 and vimPlugins.edge: init at 2021-05-08

[devins2518]

Motivation for this change

Adds vim-easyescape and the edge colorscheme plugins

Things done

Tested that both plugins build correctly using nix-build -A vimPlugins.vim-easyescape and nix-build -A vimPlugins.edge

• Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Determined the impact on package closure size (by running nix path-info -S before and after)
• Ensured that relevant documentation is up to date
• Fits CONTRIBUTING.md.

[r-rmcgibbo]

Result of nixpkgs-review pr 123113 at f72e84c0 run on aarch64-linux 1

2 packages built successfully:

• spacevim
• vimPlugins.telescope-fzy-native-nvim

2 suggestions:

• warning: missing-phase-hooks

  buildPhase should probably contain runHook preBuild and runHook postBuild.

  Near pkgs/misc/vim-plugins/build-vim-plugin.nix:28:14:

     |
  28 |       inherit unpackPhase configurePhase buildPhase addonInfo preInstall postInstall;
     |              ^
  

• warning: missing-phase-hooks

  configurePhase should probably contain runHook preConfigure and runHook postConfigure.

  Near pkgs/misc/vim-plugins/build-vim-plugin.nix:28:14:

     |
  28 |       inherit unpackPhase configurePhase buildPhase addonInfo preInstall postInstall;
     |              ^
  

---

Result of nixpkgs-review pr 123113 at f72e84c0 run on x86_64-linux 1

17 packages built successfully:

• spacevim
• vimPlugins.aniseed
• vimPlugins.chadtree
• vimPlugins.conjure
• vimPlugins.denite-nvim
• vimPlugins.edge
• vimPlugins.nvim-bqf
• vimPlugins.nvim-hlslens
• vimPlugins.telescope-frecency-nvim
• vimPlugins.telescope-fzf-writer-nvim
• vimPlugins.telescope-fzy-native-nvim
• vimPlugins.telescope-nvim
• vimPlugins.telescope-symbols-nvim
• vimPlugins.telescope-z-nvim
• vimPlugins.trouble-nvim
• vimPlugins.vim-easyescape
• vimPlugins.vim-quickrun

2 suggestions:

• warning: missing-phase-hooks

  configurePhase should probably contain runHook preConfigure and runHook postConfigure.

  Near pkgs/misc/vim-plugins/build-vim-plugin.nix:28:14:

     |
  28 |       inherit unpackPhase configurePhase buildPhase addonInfo preInstall postInstall;
     |              ^
  

• warning: missing-phase-hooks

  buildPhase should probably contain runHook preBuild and runHook postBuild.

  Near pkgs/misc/vim-plugins/build-vim-plugin.nix:28:14:

     |
  28 |       inherit unpackPhase configurePhase buildPhase addonInfo preInstall postInstall;
     |              ^
  

[SuperSandro2000]

@devins2518 please resolve the merge conflict.

[jonringer]

@devins2518 please resolve the merge conflict.

likely, you can just drop the update commit, and this should be fine

[devins2518]

Ok, that should fix it

[jonringer]

LGTM

Result of nixpkgs-review pr 123113 run on x86_64-linux 1

3 packages built:

• spacevim
• vimPlugins.edge
• vimPlugins.vim-easyescape