Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kotlin: 1.4.32 -> 1.5.0 #123116

Merged
merged 1 commit into from May 17, 2021
Merged

Conversation

SubhrajyotiSen
Copy link
Member

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@r-rmcgibbo
Copy link

Result of nixpkgs-review pr 123116 at e20a3b43 run on x86_64-linux 1

1 package built successfully:
  • kotlin
2 suggestions:
  • warning: maintainers-missing

    Package does not have a maintainer. Consider adding yourself?

    Near pkgs/development/compilers/kotlin/default.nix:40:5:

       |
    40 |     maintainers = with lib.maintainers;
       |     ^
    
  • warning: missing-phase-hooks

    installPhase should probably contain runHook preInstall and runHook postInstall.

    Near pkgs/development/compilers/kotlin/default.nix:15:3:

       |
    15 |   installPhase = ''
       |   ^
    

@SuperSandro2000 SuperSandro2000 added the 9.needs: maintainer Package or module needs active maintainers label May 17, 2021
@SuperSandro2000 SuperSandro2000 merged commit cf6be14 into NixOS:master May 17, 2021
@SubhrajyotiSen
Copy link
Member Author

@SuperSandro2000 Since you marked it as 'needs maintainer', I want to maintain Kotlin. Should I create a PR and assign myself as a maintainer?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants