Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minio: 2021-04-22T15-44-28Z -> 2021-05-11T23-27-41Z #123130

Merged
merged 1 commit into from May 15, 2021

Conversation

NULLx76
Copy link
Member

@NULLx76 NULLx76 commented May 15, 2021

Motivation for this change

https://github.com/minio/minio/releases/tag/RELEASE.2021-05-11T23-27-41Z

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@r-rmcgibbo
Copy link

r-rmcgibbo commented May 15, 2021

Result of nixpkgs-review pr 123130 at 2de1fcb5 run on x86_64-linux 1

1 package built successfully:
  • minio
1 suggestion:
  • warning: patch-phase

    patchPhase should not be overridden, use postPatch instead.

    Near pkgs/servers/minio/default.nix:33:3:

       |
    33 |   patchPhase = ''
       |   ^
    

Result of nixpkgs-review pr 123130 at 2de1fcb5 run on aarch64-linux 1

1 package built successfully:
  • minio
1 suggestion:
  • warning: patch-phase

    patchPhase should not be overridden, use postPatch instead.

    Near pkgs/servers/minio/default.nix:33:3:

       |
    33 |   patchPhase = ''
       |   ^
    

@SuperSandro2000 SuperSandro2000 merged commit a7956ba into NixOS:master May 15, 2021
@NULLx76 NULLx76 deleted the update-minio branch May 15, 2021 19:31
06kellyjac added a commit to 06kellyjac/nixpkgs that referenced this pull request May 16, 2021
Update from NixOS#123130 has moved from Apache 2.0 to AGPLv3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants