Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tinydns: test more requests #123131

Closed
wants to merge 2 commits into from
Closed

Tinydns: test more requests #123131

wants to merge 2 commits into from

Conversation

ThibautMarty
Copy link
Member

@ThibautMarty ThibautMarty commented May 15, 2021 •
edited

Motivation for this change

Related to #119066.
This does NOT fix the issue and the test currently does NOT pass.
This adds a test to ensure that the case will be tested and a fix will not regress.

Let me know what you think: the loop should be done in python or in bash? Is testing 100 times OK? It fails currently on my machine after 9 successful requests but since this is memory-related it's not trivial to design a good test.

I also added a link between the package and the test, like #118442.

cc @jerith666

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ThibautMarty
tinydns: test more requests
fc51deb 
Since glibc-2.32, tinydns stopped answering requests after a few
successful one because of its resource limits.
This bug is vicious because testing only one request does not trigger
it. Testing more requests will ensure that a patch will not regress.
@ThibautMarty
djbdns: add link to tinydns nixos test
fa09d5d
@ThibautMarty ThibautMarty changed the title Tinydns test Tinydns test more requests May 15, 2021
@ThibautMarty ThibautMarty changed the title Tinydns test more requests Tinydns: test more requests May 15, 2021
@jerith666
Copy link
Contributor

Nice test, thanks! I dropped the patch from #119066 into a commit on top of it, and it makes the test pass: cd93fa3. I'd say let's just merge all of this now, and if other parts of djbdns end up needing similar treatment, we can handle them later.

@ThibautMarty
Copy link
Member Author

I'm fine with that.

I forget to cc @basvandijk who write the initial test and use(d) tinydns.

@ThibautMarty
Copy link
Member Author

Done in #145093

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ThibautMarty @jerith666