Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Libwebsockets: add and use 4.2.0 as default #123137

Merged
merged 3 commits into from Jul 14, 2021

Conversation

Mindavi
Copy link
Contributor

@Mindavi Mindavi commented May 15, 2021

Motivation for this change

Add a libwebsockets version 4.2.0 and make it default. I think it's most logical to track the latest version, and I got everything to build.

Depends on #123135 for a successful ttyd build.

Please also look at the commit messages, I'm not sure if they're fully conforming the standards.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Mindavi Mindavi mentioned this pull request May 15, 2021
10 tasks
@Mindavi Mindavi changed the title Libwebsockets: 4.2.0 Libwebsockets: use 4.2.0 as default May 15, 2021
@Mindavi Mindavi changed the title Libwebsockets: use 4.2.0 as default Libwebsockets: add and use 4.2.0 as default May 15, 2021
@r-rmcgibbo
Copy link

r-rmcgibbo commented May 15, 2021

Result of nixpkgs-review pr 123137 at 7d0eb78 run on aarch64-linux 1

1 package failed to build:
3 packages skipped due to time constraints:
  • ardour
  • collectd
  • collectd-data
8 packages built successfully:
  • domoticz
  • driftnet
  • libwebsockets (libwebsockets_4_2)
  • libwebsockets_3_1
  • libwebsockets_3_2
  • libwebsockets_4_0
  • libwebsockets_4_1
  • mosquitto

Note that build failures may predate this PR, and could be nondeterministic or hardware dependent.
Please exercise your independent judgement. Does something look off? Please file an issue or reach out on IRC.


Result of nixpkgs-review pr 123137 at 0891da9 run on x86_64-linux 1

2 packages marked as broken and skipped:
  • libwebsockets_4_0
  • libwebsockets_4_1
2 packages failed to build:
8 packages built successfully:
  • collectd
  • collectd-data
  • domoticz
  • driftnet
  • libwebsockets (libwebsockets_4_2)
  • libwebsockets_3_1
  • libwebsockets_3_2
  • mosquitto

Note that build failures may predate this PR, and could be nondeterministic or hardware dependent.
Please exercise your independent judgement. Does something look off? Please file an issue or reach out on IRC.

Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mosquitto seems the only one that requires the 3.x serie but that's something for another PR.

pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
@Mindavi
Copy link
Contributor Author

Mindavi commented May 15, 2021

I was already wondering if I should keep around all those old versions. Thanks for pushing me over the edge to do so :). Mosquitto compiles fine with libwebsockets 4.2, so we can bump that one / move to the default version and then remove all the 3.x series, I think. Will prepare a PR for that.

@Mindavi
Copy link
Contributor Author

Mindavi commented Jun 21, 2021

@fabaff got some time to look at this? Should be good to go.

@symphorien symphorien merged commit 2bd1e82 into NixOS:master Jul 14, 2021
@Mindavi Mindavi deleted the libwebsockets/4.2.0 branch July 14, 2021 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants