New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Libwebsockets: add and use 4.2.0 as default #123137
Conversation
Result of 1 package failed to build:3 packages skipped due to time constraints:
8 packages built successfully:
Note that build failures may predate this PR, and could be nondeterministic or hardware dependent. Result of 2 packages marked as broken and skipped:
8 packages built successfully:
Note that build failures may predate this PR, and could be nondeterministic or hardware dependent. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mosquitto seems the only one that requires the 3.x serie but that's something for another PR.
I was already wondering if I should keep around all those old versions. Thanks for pushing me over the edge to do so :). Mosquitto compiles fine with libwebsockets 4.2, so we can bump that one / move to the default version and then remove all the 3.x series, I think. Will prepare a PR for that. |
@fabaff got some time to look at this? Should be good to go. |
Motivation for this change
Add a libwebsockets version 4.2.0 and make it default. I think it's most logical to track the latest version, and I got everything to build.
Depends on #123135 for a successful ttyd build.
Please also look at the commit messages, I'm not sure if they're fully conforming the standards.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)