zathura: disable checkPhase on Darwin #123140
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Zathura currently fails to build for Darwin on Hydra during the check phase. Interestingly, the build succeeds on my machine even with the sandbox enabled. Since the resulting binary worked without problems, I just disabled the check phase for Zathura.
Looking at the Hydra build logs, the failure seems to originate from the window system, so there might be some impurities involed.
ZHF: #122042
Failing build: https://hydra.nixos.org/build/142613284
ping @NixOS/nixos-release-managers
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)