zprint: init at 1.1.2 #123150
zprint: init at 1.1.2 #123150
Conversation
|
Hey! This is my first attempt at not only NixOS packaging, but linux packaging in general. I based this derivation on the babashka derivation, since they are both built with graalvm-ce. One thing that was confusing was that babashka uses graalvm11-ce.meta.platforms which evaluates to [ "x86_64-linux" "x86_64-darwin" ] but on search.nixos.org babashka platforms appear as only "x86_64-linux". How does that work? Both packages can only build on x86_64-linux I believe because GraalVM requires a license to build a native-image on Darwin. |
| src = fetchurl { | ||
| url = | ||
| "https://github.com/kkinnear/${pname}/releases/download/${version}/${pname}-filter-${version}"; | ||
| sha256 = "1wh8jyj7alfa6h0cycfwffki83wqb5d5x0p7kvgdkhl7jx7isrwj"; | ||
| }; |
There was a problem hiding this comment.
use fetchFromGitHub instead
And I think compiling the archive, based on the source code, is better than downloading it and then running some command on it. But someone else should confirm that
| mkdir -p $out/bin | ||
| cp ${pname} $out/bin/${pname} |
There was a problem hiding this comment.
can be replaced with the install command
|
Result of 1 package built:
|
| with lib; | ||
| stdenv.mkDerivation rec { |
There was a problem hiding this comment.
| with lib; | |
| stdenv.mkDerivation rec { | |
| stdenv.mkDerivation rec { |
| cp ${pname} $out/bin/${pname} | ||
| ''; | ||
|
|
||
| meta = { |
There was a problem hiding this comment.
| meta = { | |
| meta = with lib; { |
|
Thanks for the contribution! Do you mind making the changes above (splitting out the maintainer addition to a separate commit) as well as rebasing to remove the merge commit? |
Motivation for this change
Adding zprint to nixpkgs, a clojure pretty printer and source code formatter.
Things done
Added myself to the maintainer list, added derivation for zprint
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)