Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tup: 0.7.10 -> 0.7.11 #123157

Merged
merged 1 commit into from May 18, 2021
Merged

tup: 0.7.10 -> 0.7.11 #123157

merged 1 commit into from May 18, 2021

Conversation

ehmry
Copy link
Contributor

@ehmry ehmry commented May 15, 2021

Motivation for this change

New features:

  • ^t flag can be used to mark commands with "transient" outputs. These
    outputs are
    removed after all dependent commands have been processed. (See the manual
    for details if you think this will be useful for you)
  • Internal lua version is now 5.4.3

Bug fixes:

  • Environment variable changes now show in --debug-logging logs
  • Including a lua file from a regular Tupfile no longer breaks updating
    variables w
    ith +=
  • tup32detect.exe no longer gets flagged as a virus (
    Security warning in chrome gittup/tup#411)
  • Tup now detects if it is running inside of Conemu's dependency injection
    and issues a warning
  • Changing external files now correctly re-parses if full_deps=1 (thanks
    alightr!)
  • 'tup varsed' now works inside a 'tup generate' script
  • Fixes to the progress bar that sometimes showed a non-zero ending state.
  • Argument ordering for partial updates is no longer strict (both 'tup
    filename -k' and 'tup -k filename' should work to update filename with the
    keep-going flag enabled).
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@r-rmcgibbo
Copy link

r-rmcgibbo commented May 15, 2021

Result of nixpkgs-review pr 123157 at 588e045 run on x86_64-linux 1

1 package built successfully:
  • tup
2 suggestions:
  • warning: unclear-gpl

    gpl2 is a deprecated license, please check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.

    Near pkgs/development/tools/build-managers/tup/default.nix:57:5:

       |
    57 |     license = licenses.gpl2;
       |     ^
    
  • warning: missing-phase-hooks

    configurePhase should probably contain runHook preConfigure and runHook postConfigure.

    Near pkgs/development/tools/build-managers/tup/default.nix:20:3:

       |
    20 |   configurePhase = ''
       |   ^
    

Result of nixpkgs-review pr 123157 at 588e045 run on aarch64-linux 1

1 package built successfully:
  • tup

Copy link
Member

@bbjubjub2494 bbjubjub2494 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SuperSandro2000 SuperSandro2000 merged commit a5a8ef1 into NixOS:master May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants