Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vdr: 2.4.6 -> 2.4.7 #123168

Merged
merged 2 commits into from May 16, 2021
Merged

vdr: 2.4.6 -> 2.4.7 #123168

merged 2 commits into from May 16, 2021

Conversation

ck3d
Copy link
Contributor

@ck3d ck3d commented May 15, 2021

Motivation for this change

Update to latest version.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@r-rmcgibbo
Copy link

Result of nixpkgs-review pr 123168 at d5d750f run on x86_64-linux 1

2 packages marked as broken and skipped:
  • vdrPlugins.markad
  • vdrPlugins.xineliboutput
9 packages built successfully:
  • vdr
  • vdrPlugins.epgsearch
  • vdrPlugins.femon
  • vdrPlugins.fritzbox
  • vdrPlugins.skincurses
  • vdrPlugins.text2skin
  • vdrPlugins.vaapidevice
  • vdrPlugins.vnsiserver
  • wrapVdr
1 suggestion:
  • warning: unclear-gpl

    gpl2 is a deprecated license, please check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.

    Near pkgs/applications/video/vdr/default.nix:54:5:

       |
    54 |     license = licenses.gpl2;
       |     ^
    

@ck3d
Copy link
Contributor Author

ck3d commented May 16, 2021

I updated the license as suggested, but now the editor config check failed for unknown reason. The marked broken packages uses an insecure libav, which we should ignore for this PR.

@markuskowa
Copy link
Member

@GrahamcOfBorg eval

@markuskowa markuskowa merged commit 0e5545a into NixOS:master May 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants