Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.garages-amsterdam: init at 2.1.0 #123177

Merged
merged 1 commit into from Jun 1, 2021

Conversation

fabaff
Copy link
Member

@fabaff fabaff commented May 15, 2021

Motivation for this change

Python client for getting garage occupancy in Amsterdam

https://github.com/klaasnicolaas/garages_amsterdam

This is Home Assistant dependency. Integration will be introduced with 2021.6.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@fabaff
Copy link
Member Author

fabaff commented May 15, 2021

Result of nixpkgs-review pr 123177 run on x86_64-linux 1

2 packages built:
  • python38Packages.garages-amsterdam
  • python39Packages.garages-amsterdam

@r-rmcgibbo
Copy link

r-rmcgibbo commented May 16, 2021

Result of nixpkgs-review pr 123177 at a22b94a1 run on aarch64-linux 1

2 packages built successfully:
  • python38Packages.garages-amsterdam
  • python39Packages.garages-amsterdam

Result of nixpkgs-review pr 123177 at a22b94a1 run on x86_64-linux 1

2 packages built successfully:
  • python38Packages.garages-amsterdam
  • python39Packages.garages-amsterdam

@fabaff fabaff added this to To do in Home Assistant via automation May 19, 2021
@fabaff fabaff moved this from To do to On Hold in Home Assistant May 19, 2021
Home Assistant automation moved this from On Hold to Reviewed May 23, 2021
@fabaff fabaff changed the title python3Packages.garages-amsterdam: init at 2.0.4 python3Packages.garages-amsterdam: init at 2.1.0 May 29, 2021
@SuperSandro2000 SuperSandro2000 merged commit 38e8810 into NixOS:master Jun 1, 2021
Home Assistant automation moved this from Reviewed to Done Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants