Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.flask-appbuilder: 3.2.3 -> 3.3.0 #123223

Merged
merged 1 commit into from May 19, 2021

Conversation

fabaff
Copy link
Member

@fabaff fabaff commented May 16, 2021

Motivation for this change

Update to latest upstream release 3.3.0

Change log: https://github.com/dpgaspar/Flask-AppBuilder/releases/tag/v3.3.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@r-rmcgibbo
Copy link

r-rmcgibbo commented May 16, 2021

Result of nixpkgs-review pr 123223 at f6e587a9 run on aarch64-linux 1

1 package failed to build:
2 packages built successfully:
  • python38Packages.flask-appbuilder
  • python39Packages.flask-appbuilder

Note that build failures may predate this PR, and could be nondeterministic or hardware dependent.
Please exercise your independent judgement. Does something look off? Please file an issue or reach out on IRC.


Result of nixpkgs-review pr 123223 at f6e587a9 run on x86_64-linux 1

1 package failed to build:
2 packages built successfully:
  • python38Packages.flask-appbuilder
  • python39Packages.flask-appbuilder

Note that build failures may predate this PR, and could be nondeterministic or hardware dependent.
Please exercise your independent judgement. Does something look off? Please file an issue or reach out on IRC.

@fabaff
Copy link
Member Author

fabaff commented May 18, 2021

@ofborg eval

@fabaff fabaff force-pushed the cleanup-flask-appbuilder branch 2 times, most recently from 801ff77 to f6e4e2f Compare May 19, 2021 07:34
@fabaff fabaff merged commit d33553a into NixOS:master May 19, 2021
@fabaff fabaff deleted the cleanup-flask-appbuilder branch May 19, 2021 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants