Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pipewire: add update-config script #123325

Closed
wants to merge 1 commit into from
Closed

pipewire: add update-config script #123325

wants to merge 1 commit into from
+13 −0

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented May 17, 2021

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jtojnar
Copy link
Contributor

jtojnar commented May 17, 2021

Why not make this part of the update script? https://github.com/NixOS/nixpkgs/blob/354e005d6c7a910fd009b90360545fed8ddba4a2/pkgs/development/libraries/pipewire/update.sh

@Mic92
Copy link
Member Author

Mic92 commented May 17, 2021

This script did not exists in the branch I started adding it.

@Mic92 Mic92 closed this May 17, 2021
@Mic92 Mic92 deleted the pipewire branch May 17, 2021 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Mic92 @jtojnar