Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.croniter: 1.0.9 -> 1.0.13 #123327

Merged
merged 1 commit into from May 23, 2021
Merged

python3Packages.croniter: 1.0.9 -> 1.0.13 #123327

merged 1 commit into from May 23, 2021

Conversation

fabaff
Copy link
Member

@fabaff fabaff commented May 17, 2021

Motivation for this change

Update to latest upstream release 1.0.13

Change log: https://github.com/taichino/croniter/blob/master/docs/CHANGES.rst

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from costrouc May 17, 2021 07:37
@fabaff
Copy link
Member Author

fabaff commented May 17, 2021

Result of nixpkgs-review pr 123327 run on x86_64-linux 1

1 package failed to build:
  • apache-airflow
8 packages built:
  • home-assistant
  • python38Packages.croniter
  • python38Packages.privacyidea
  • python38Packages.python-miio
  • python39Packages.croniter
  • python39Packages.privacyidea
  • python39Packages.python-miio
  • safeeyes

@r-rmcgibbo
Copy link

r-rmcgibbo commented May 17, 2021 •
edited

Result of nixpkgs-review pr 123327 at a79be6b run on aarch64-linux 1

2 packages failed to build:
7 packages built successfully:
  • python38Packages.croniter
  • python38Packages.privacyidea
  • python38Packages.python-miio
  • python39Packages.croniter
  • python39Packages.privacyidea
  • python39Packages.python-miio
  • safeeyes

Note that build failures may predate this PR, and could be nondeterministic or hardware dependent.
Please exercise your independent judgement. Does something look off? Please file an issue or reach out on IRC.

Result of nixpkgs-review pr 123327 at a79be6b run on x86_64-linux 1

1 package failed to build:
8 packages built successfully:
  • home-assistant
  • python38Packages.croniter
  • python38Packages.privacyidea
  • python38Packages.python-miio
  • python39Packages.croniter
  • python39Packages.privacyidea
  • python39Packages.python-miio
  • safeeyes

Note that build failures may predate this PR, and could be nondeterministic or hardware dependent.
Please exercise your independent judgement. Does something look off? Please file an issue or reach out on IRC.

@fabaff fabaff merged commit bda6a9c into NixOS:master May 23, 2021
@fabaff fabaff deleted the bump-croniter branch May 23, 2021 10:00
@fabaff fabaff mentioned this pull request Jun 22, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@costrouc costrouc Awaiting requested review from costrouc

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fabaff @r-rmcgibbo