Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libidn: 1.36 -> 1.37 #123330

Merged
merged 3 commits into from May 23, 2021
Merged

libidn: 1.36 -> 1.37 #123330

merged 3 commits into from May 23, 2021

Conversation

lsix
Copy link
Member

@lsix lsix commented May 17, 2021

Motivation for this change

See https://lists.gnu.org/archive/html/info-gnu/2021-05/msg00012.html
for release information.

This release is announced as API and ABI compatible.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@r-rmcgibbo
Copy link

r-rmcgibbo commented May 17, 2021

Result of nixpkgs-review pr 123330 at ef3582ce run on aarch64-linux 1

1011 packages marked as broken and skipped:
  • Literate
  • OVMF-CSM
  • adoptopenjdk-hotspot-bin-13
  • adoptopenjdk-hotspot-bin-14
  • adoptopenjdk-jre-hotspot-bin-13
  • adoptopenjdk-jre-hotspot-bin-14
  • agdaPackages.iowa-stdlib
  • aldor
  • ams-lv2
  • amuleDaemon
  • ...
16032 packages skipped due to time constraints:
  • AusweisApp2
  • CHOWTapeModel
  • DisnixWebService
  • EBTKS
  • EmptyEpsilon
  • Fabric (python38Packages.Fabric)
  • MIDIVisualizer
  • MMA
  • OVMF
  • OVMF-secureBoot
  • ...
9 packages built successfully:
  • curl
  • libidn
  • libmysqlclient (libmysqlclient_3_1 ,mariadb-connector-c ,mariadb-connector-c_3_1)
  • lua51Packages.luarocks
  • luarocks (luaPackages.luarocks)
  • lua53Packages.luarocks
  • luajitPackages.luarocks
  • passExtensions.pass-checkup
  • slack-cli
1 suggestion:
  • warning: maintainers-missing

    Package does not have a maintainer. Consider adding yourself?

    Near pkgs/development/libraries/libidn/default.nix:45:5:

       |
    45 |     maintainers = [ ];
       |     ^
    

Result of nixpkgs-review pr 123330 at ef3582ce run on x86_64-linux 1

931 packages marked as broken and skipped:
  • adobe-reader
  • adoptopenjdk-hotspot-bin-13
  • adoptopenjdk-hotspot-bin-14
  • adoptopenjdk-jre-hotspot-bin-13
  • adoptopenjdk-jre-hotspot-bin-14
  • adoptopenjdk-jre-openj9-bin-13
  • adoptopenjdk-jre-openj9-bin-14
  • adoptopenjdk-openj9-bin-13
  • adoptopenjdk-openj9-bin-14
  • agdaPackages.iowa-stdlib
  • ...
17868 packages skipped due to time constraints:
  • AusweisApp2
  • CHOWTapeModel
  • DisnixWebService
  • EBTKS
  • EmptyEpsilon
  • Fabric (python38Packages.Fabric)
  • Literate
  • MIDIVisualizer
  • MMA
  • OSCAR
  • ...
13 packages built successfully:
  • curl
  • imgurbash2
  • libidn
  • libmysqlclient (libmysqlclient_3_1 ,mariadb-connector-c ,mariadb-connector-c_3_1)
  • lua51Packages.luarocks
  • luarocks (luaPackages.luarocks)
  • lua53Packages.luarocks
  • luajitPackages.basexx
  • luajitPackages.luarocks
  • roswell
  • rubyPackages_3_0.curb
  • slack-cli
  • trafficserver
1 suggestion:
  • warning: maintainers-missing

    Package does not have a maintainer. Consider adding yourself?

    Near pkgs/development/libraries/libidn/default.nix:45:5:

       |
    45 |     maintainers = [ ];
       |     ^
    

See https://lists.gnu.org/archive/html/info-gnu/2021-05/msg00012.html
for release information.

This release is announced as API and ABI compatible.
@lsix
Copy link
Member Author

lsix commented May 18, 2021

@SuperSandro2000 I have done the changes as requested.

I have also re-enabled tests that where disabled for ages (there where report of test failure with gcc-7), and build it successfully. I however have not been able to test the build on darwin (no box available), I’ll see if hydra reports an error.

I have also added myself as maintainer as the package was maintainer-less.

lsix added 2 commits May 18, 2021 13:05
Tests where disabled for a long time, but they seem to pass now.

Succesfully built libidn and pkgsMusl.libidn on linux-x86_64.
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM

@lukegb lukegb merged commit 0d8bc21 into NixOS:staging May 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants