Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libextractor: use ffmpeg instead of ffmpeg_3 #123344

Merged
merged 1 commit into from May 20, 2021
Merged

libextractor: use ffmpeg instead of ffmpeg_3 #123344

merged 1 commit into from May 20, 2021

Conversation

dotlambda
Copy link
Member

@dotlambda dotlambda commented May 17, 2021 •
edited

Motivation for this change

#120705

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

I only made sure that it builds, not that it works.

cc gnunet (which uses this package) maintainers @vrthra @pstn

@dotlambda dotlambda requested a review from jorsn May 17, 2021 09:53
@dotlambda dotlambda mentioned this pull request May 17, 2021
Closed
@r-rmcgibbo
Copy link

r-rmcgibbo commented May 17, 2021 •
edited

Result of nixpkgs-review pr 123344 at c06b7e8 run on x86_64-linux 1

1 package marked as broken and skipped:
  • vdrPlugins.xineliboutput
4 packages built successfully:
  • doodle
  • gnunet
  • gnunet-gtk
  • libextractor
3 suggestions:
  • warning: build-tools-in-build-inputs

    pkg-config is a build tool so it likely goes to nativeBuildInputs, not buildInputs.

    Near pkgs/development/libraries/libextractor/default.nix:48:3:

       |
48 |   buildInputs =
   |   ^
  • warning: build-tools-in-build-inputs

    rpm is a build tool so it likely goes to nativeBuildInputs, not buildInputs.

    Near pkgs/development/libraries/libextractor/default.nix:48:3:

       |
48 |   buildInputs =
   |   ^
  • warning: build-tools-in-build-inputs

    libtool is a build tool so it likely goes to nativeBuildInputs, not buildInputs.

    Near pkgs/development/libraries/libextractor/default.nix:48:3:

       |
48 |   buildInputs =
   |   ^

Result of nixpkgs-review pr 123344 at c06b7e8 run on aarch64-linux 1

4 packages built successfully:
  • doodle
  • gnunet
  • gnunet-gtk
  • libextractor

@dotlambda dotlambda added this to the 21.05 milestone May 20, 2021
@dotlambda dotlambda requested a review from vrthra May 20, 2021 11:38
@dotlambda dotlambda added the 9.needs: maintainer Package or module needs active maintainers label May 20, 2021
@pstn
Copy link
Contributor

pstn commented May 20, 2021

lgtm 👍

@dotlambda dotlambda merged commit 1f065ca into NixOS:master May 20, 2021
@dotlambda dotlambda deleted the libextractor-ffmpeg branch May 20, 2021 22:43
@jorsn
Copy link
Member

jorsn commented May 20, 2021 •
edited

Thanks, I was very busy! Will push a version update at the weekend if the new version works smoothly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prusnak prusnak prusnak approved these changes

@jorsn jorsn Awaiting requested review from jorsn

@vrthra vrthra Awaiting requested review from vrthra

Assignees
No one assigned
Labels
9.needs: maintainer Package or module needs active maintainers 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
21.05
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dotlambda @r-rmcgibbo @pstn @jorsn @prusnak