Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lens: init at 4.2.4 #123358

Closed
wants to merge 1 commit into from
Closed

lens: init at 4.2.4 #123358

wants to merge 1 commit into from

Conversation

glottologist
Copy link

@glottologist glottologist commented May 17, 2021

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@legendofmiracles
Copy link
Contributor

legendofmiracles commented May 17, 2021

Any reason why are you extracting the appimage, instead of compiling it from source?
The nixpkgs manual has this to say on appimages:

They are meant to be used if traditional packaging from source is infeasible, or it would take too long.

@glottologist
Copy link
Author

There are issues with the Yarn version that is installed when building on NixOS from source. I can retroactively change the pkg to build from source once that is fixed

@teto
Copy link
Member

teto commented May 17, 2021

would this replace pkgs/applications/networking/cluster/lens/default.nix ?

@glottologist
Copy link
Author

I hadn't seen cluster lens so this can be closed in favour of that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants