Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/nebula: Add release notes #123442

Merged
merged 1 commit into from May 19, 2021
Merged

Conversation

Jaculabilis
Copy link
Contributor

@Jaculabilis Jaculabilis commented May 18, 2021

Motivation for this change

The Nebula module is new in 21.05 via #111518.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@lukegb
Copy link
Contributor

lukegb commented May 18, 2021

@NixOS/release-engineers

@Ma27
Copy link
Member

Ma27 commented May 19, 2021

Aren't those additions generated via a script before the release?

@Jaculabilis
Copy link
Contributor Author

@Ma27 There are already some services listed here, so I figured at least some things are added manually. Is there an existing process documented or hinted at somewhere?

@jonringer
Copy link
Contributor

Aren't those additions generated via a script before the release?

If you mean, I run some scripts and then manually prune and improve them. Yes. They are generated :)

@jonringer jonringer merged commit 420b0fa into NixOS:master May 19, 2021
@Jaculabilis Jaculabilis deleted the nebula-relnotes branch May 19, 2021 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants