Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

betterlockscreen: 3.0.1 -> 3.1.0 #123457

Merged
merged 1 commit into from May 21, 2021
Merged

Conversation

jack-michaud
Copy link
Contributor

@jack-michaud jack-michaud commented May 18, 2021

Motivation for this change

Updates to latest version that has some bugfixes. A big one for me is that the screen no longer flashes white when locking.

Changes introduced (diff)

Things done

Note: new version of betterlockscreen uses i3lock-color directly, so the relevant patch was removed.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@r-rmcgibbo
Copy link

r-rmcgibbo commented May 18, 2021

Result of nixpkgs-review pr 123457 at d1a2274 run on x86_64-linux 1

2 packages built successfully:
  • betterlockscreen
  • tests.trivial
1 suggestion:
  • warning: missing-phase-hooks

    installPhase should probably contain runHook preInstall and runHook postInstall.

    Near pkgs/misc/screensavers/betterlockscreen/default.nix:19:3:

       |
    19 |   installPhase =
       |   ^
    

Result of nixpkgs-review pr 123457 at d1a2274 run on aarch64-linux 1

1 package built successfully:
  • betterlockscreen
1 suggestion:
  • warning: missing-phase-hooks

    installPhase should probably contain runHook preInstall and runHook postInstall.

    Near pkgs/misc/screensavers/betterlockscreen/default.nix:19:3:

       |
    19 |   installPhase =
       |   ^
    

@Ma27 Ma27 merged commit 12a9bd6 into NixOS:master May 21, 2021
@eyJhb
Copy link
Member

eyJhb commented May 26, 2021

@jack-michaud

Note: new version of betterlockscreen uses i3lock-color directly, so the relevant patch was removed.

This was reverted back... https://github.com/pavanjadhaw/betterlockscreen/releases/tag/3.1.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants