Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.spacy: 3.0.5 -> 3.0.6 #123461

Merged
merged 4 commits into from May 18, 2021
Merged

Conversation

danieldk
Copy link
Contributor

Motivation for this change

spaCy switched from plac to typer for CLI handling.

Also update all transitive dependencies that need updates.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

catalogue now vendors importlib-metadata, so the importlib-metadata
dependency is obsolete.
@r-rmcgibbo
Copy link

r-rmcgibbo commented May 18, 2021

Result of nixpkgs-review pr 123461 at 73f060fc run on x86_64-linux 1

1 package marked as broken and skipped:
  • python38Packages.textacy
1 package skipped due to time constraints:
  • tests.trivial
10 packages built successfully:
  • python38Packages.catalogue
  • python38Packages.spacy
  • python38Packages.spacy-pkuseg
  • python38Packages.spacy-transformers
  • python38Packages.srsly
  • python38Packages.thinc
  • python39Packages.catalogue
  • python39Packages.spacy-pkuseg
  • python39Packages.srsly
  • python39Packages.thinc
3 suggestions:
  • warning: maintainers-missing

    Package does not have a maintainer. Consider adding yourself?

    Near pkgs/development/python-modules/srsly/default.nix:42:3:

       |
    42 |   meta = with lib; {
       |   ^
    
  • warning: unused-argument

    Unused argument: pathlib.
    Near pkgs/development/python-modules/srsly/default.nix:9:3:

      |
    9 | , pathlib
      |   ^
    
  • warning: maintainers-missing

    Package does not have a maintainer. Consider adding yourself?

    Near pkgs/development/python-modules/catalogue/default.nix:21:3:

       |
    21 |   meta = with lib; {
       |   ^
    

Result of nixpkgs-review pr 123461 at 73f060fc run on aarch64-linux 1

5 packages marked as broken and skipped:
  • python38Packages.spacy
  • python38Packages.spacy-transformers
  • python38Packages.textacy
  • python38Packages.thinc
  • python39Packages.thinc
6 packages built successfully:
  • python38Packages.catalogue
  • python38Packages.spacy-pkuseg
  • python38Packages.srsly
  • python39Packages.catalogue
  • python39Packages.spacy-pkuseg
  • python39Packages.srsly
3 suggestions:
  • warning: maintainers-missing

    Package does not have a maintainer. Consider adding yourself?

    Near pkgs/development/python-modules/catalogue/default.nix:21:3:

       |
    21 |   meta = with lib; {
       |   ^
    
  • warning: unused-argument

    Unused argument: pathlib.
    Near pkgs/development/python-modules/srsly/default.nix:9:3:

      |
    9 | , pathlib
      |   ^
    
  • warning: maintainers-missing

    Package does not have a maintainer. Consider adding yourself?

    Near pkgs/development/python-modules/srsly/default.nix:42:3:

       |
    42 |   meta = with lib; {
       |   ^
    

@globin globin merged commit 0f03634 into NixOS:master May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants