Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

renpy: ffmpeg_3 -> ffmpeg #123464

Merged
merged 1 commit into from May 20, 2021
Merged

renpy: ffmpeg_3 -> ffmpeg #123464

merged 1 commit into from May 20, 2021

Conversation

FliegendeWurst
Copy link
Member

Motivation for this change

#120705

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dotlambda dotlambda added the 9.needs: maintainer Package or module needs active maintainers label May 18, 2021
@r-rmcgibbo
Copy link

r-rmcgibbo commented May 18, 2021

Result of nixpkgs-review pr 123464 at 9e16b3b run on x86_64-linux 1

2 packages built successfully:
  • renpy
  • tests.trivial
5 suggestions:
  • warning: maintainers-missing

    Package does not have a maintainer. Consider adding yourself?

    Near pkgs/development/interpreters/renpy/default.nix:12:3:

       |
    12 |   meta = with lib; {
       |   ^
    
  • warning: build-tools-in-build-inputs

    python2.pkgs.wrapPython is a build tool so it likely goes to nativeBuildInputs, not buildInputs.

    Near pkgs/development/interpreters/renpy/default.nix:33:3:

       |
    33 |   buildInputs = [
       |   ^
    
  • warning: missing-phase-hooks

    buildPhase should probably contain runHook preBuild and runHook postBuild.

    Near pkgs/development/interpreters/renpy/default.nix:44:3:

       |
    44 |   buildPhase = ''
       |   ^
    
  • warning: missing-phase-hooks

    installPhase should probably contain runHook preInstall and runHook postInstall.

    Near pkgs/development/interpreters/renpy/default.nix:48:3:

       |
    48 |   installPhase = ''
       |   ^
    
  • warning: missing-patch-comment

    Consider adding a comment explaining the purpose of this patch on the line preceeding.
    Near pkgs/development/interpreters/renpy/default.nix:25:5:

       |
    25 |     ./launcherenv.patch
       |     ^
    

Result of nixpkgs-review pr 123464 at 9e16b3b run on aarch64-linux 1

1 package built successfully:
  • renpy

@dotlambda dotlambda added this to the 21.05 milestone May 20, 2021
@Ma27 Ma27 merged commit a5e7467 into NixOS:master May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants