Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

yaxg: use ffmpeg instead of ffmpeg_3 #123474

Merged
merged 1 commit into from Jun 30, 2021
Merged

yaxg: use ffmpeg instead of ffmpeg_3 #123474

merged 1 commit into from Jun 30, 2021

Conversation

dotlambda
Copy link
Member

Motivation for this change

#120705

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dotlambda dotlambda mentioned this pull request May 18, 2021
Closed
@r-rmcgibbo
Copy link

Result of nixpkgs-review pr 123474 at d496275 run on x86_64-linux 1

2 packages built successfully:
  • tests.trivial
  • yaxg
1 suggestion:
  • warning: missing-phase-hooks

    installPhase should probably contain runHook preInstall and runHook postInstall.

    Near pkgs/tools/graphics/yaxg/default.nix:18:3:

       |
18 |   installPhase = ''
   |   ^

@dotlambda dotlambda added this to the 21.05 milestone May 20, 2021
@neonfuz
Copy link
Contributor

neonfuz commented Jun 27, 2021

Tested and working

Why wasn't I pinged even though I'm the maintainer of yaxg?

@dotlambda
Copy link
Member Author

@neonfuz You're not a member of the @NixOS organization.
I did mention you in #120705 however.

@SuperSandro2000 SuperSandro2000 merged commit 95faf14 into NixOS:master Jun 30, 2021
@github-actions github-actions bot mentioned this pull request Jun 30, 2021
Merged
1 task
@github-actions
Copy link
Contributor

Successfully created backport PR #128699 for release-21.05.

@dotlambda dotlambda deleted the yaxg-ffmpeg branch June 30, 2021 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10
Projects
None yet
Milestone
21.05
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dotlambda @r-rmcgibbo @neonfuz @SuperSandro2000