dvd-slideshow: use ffmpeg instead of ffmpeg_3

[dotlambda]

Motivation for this change

#120705

Things done

• Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Determined the impact on package closure size (by running nix path-info -S before and after)
• Ensured that relevant documentation is up to date
• Fits CONTRIBUTING.md.

[r-rmcgibbo]

Result of nixpkgs-review pr 123489 at 0e52763 run on x86_64-linux 1

2 packages built successfully:

• dvd-slideshow
• tests.trivial

3 suggestions:

• warning: patch-phase

  patchPhase should not be overridden, use postPatch instead.

  Near pkgs/applications/video/dvd-slideshow/default.nix:39:3:

     |
  39 |   patchPhase = ''
     |   ^
  

• warning: missing-phase-hooks

  installPhase should probably contain runHook preInstall and runHook postInstall.

  Near pkgs/applications/video/dvd-slideshow/default.nix:46:3:

     |
  46 |   installPhase = ''
     |   ^
  

• warning: unclear-gpl

  gpl2 is a deprecated license, please check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.

  Near pkgs/applications/video/dvd-slideshow/default.nix:68:5:

     |
  68 |     license = lib.licenses.gpl2;
     |     ^
  

---

Result of nixpkgs-review pr 123489 at 0e52763 run on aarch64-linux 1

1 package built successfully:

• dvd-slideshow

3 suggestions:

• warning: unclear-gpl

  gpl2 is a deprecated license, please check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.

  Near pkgs/applications/video/dvd-slideshow/default.nix:68:5:

     |
  68 |     license = lib.licenses.gpl2;
     |     ^
  

• warning: missing-phase-hooks

  installPhase should probably contain runHook preInstall and runHook postInstall.

  Near pkgs/applications/video/dvd-slideshow/default.nix:46:3:

     |
  46 |   installPhase = ''
     |   ^
  

• warning: patch-phase

  patchPhase should not be overridden, use postPatch instead.

  Near pkgs/applications/video/dvd-slideshow/default.nix:39:3:

     |
  39 |   patchPhase = ''
     |   ^
  

[thiagokokada]

Result of nixpkgs-review pr 123489 run on x86_64-linux 1

1 package marked as broken and skipped:

• tests.trivial

1 package built:

• dvd-slideshow

[github-actions]

Successfully created backport PR #145829 for release-21.05.