Synology Drive Client: init at 2.0.4 #123493
Conversation
| }: | ||
|
|
||
| stdenv.mkDerivation { | ||
| name = "synology-drive-client"; |
There was a problem hiding this comment.
this should be pname, name includes the version
| dontWrapQtApps = true; | ||
|
|
||
| meta = with stdenv.lib; { | ||
| description = "synology drive client"; |
There was a problem hiding this comment.
Should be a bit more descriptive rather than restating the name of the package (see here)
|
|
||
| version = "2.0.4"; | ||
|
|
||
| system = "x86_64-linux"; |
There was a problem hiding this comment.
What is this supposed to do that meta.platforms doesn't?
| sha256 = "01f9qgqkd6m3idr5f0w2k5cl9sjk7617fzp023d0qfnsw661wy56"; | ||
| }) | ||
| (fetchurl { | ||
| url = "https://global.download.synology.com/download/Utility/SynologyDriveClient/2.0.4-11112/Ubuntu/Installer/x86_64/synology-drive-client-11112.x86_64.deb"; |
There was a problem hiding this comment.
It would be nice if this url was based on the version rather than hardcoded
|
Oh also, please follow the commit message conventions, so for your commits it would be
|
| { | ||
| stdenv |
There was a problem hiding this comment.
| { | |
| stdenv | |
| { stdenv |
| versionNumber = "2.0.4"; | ||
| in stdenv.mkDerivation { | ||
| pname = "synology-drive-client"; | ||
|
|
||
| version = versionNumber; |
There was a problem hiding this comment.
| versionNumber = "2.0.4"; | |
| in stdenv.mkDerivation { | |
| pname = "synology-drive-client"; | |
| version = versionNumber; | |
| in stdenv.mkDerivation { | |
| pname = "synology-drive-client"; | |
| version = "2.0.4"; |
| rm -rf $out/usr/lib/nautilus | ||
| rm -rf $out/opt/Synology/SynologyDrive/package/cloudstation/icon-overlay |
There was a problem hiding this comment.
| rm -rf $out/usr/lib/nautilus | |
| rm -rf $out/opt/Synology/SynologyDrive/package/cloudstation/icon-overlay | |
| rm -r $out/usr/lib/nautilus | |
| rm -r $out/opt/Synology/SynologyDrive/package/cloudstation/icon-overlay |
| done | ||
| rm -rf $out/usr/lib/nautilus | ||
| rm -rf $out/opt/Synology/SynologyDrive/package/cloudstation/icon-overlay | ||
| cp -r $out/usr/bin $out/bin |
There was a problem hiding this comment.
We should probably copy the files out of opt.
| dontWrapQtApps = true; | ||
|
|
||
| meta = with lib; { | ||
| description = "Desktop application to synchronize files and folders between the computer and the Synology Drive server to access, browse, and share files via file browser"; |
There was a problem hiding this comment.
| description = "Desktop application to synchronize files and folders between the computer and the Synology Drive server to access, browse, and share files via file browser"; | |
| description = "Desktop application to synchronize files and folders between the computer and the Synology Drive server"; |
otherwise it is a bit long. Maybe add the full to longDescription.
|
close for #144706 new version |
Motivation for this change
Add Synology Drive Client
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)