Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spacenavd: fix darwin build #123508

Merged
merged 1 commit into from May 19, 2021
Merged

spacenavd: fix darwin build #123508

merged 1 commit into from May 19, 2021

Conversation

stephank
Copy link
Contributor

@stephank stephank commented May 18, 2021 •
edited

Motivation for this change

ZHF: #122042
cc @NixOS/nixos-release-managers

Hydra failure: https://hydra.nixos.org/build/142946017/nixlog/1

Upstream PR: FreeSpacenav/spacenavd#38

Draft, because we may have to wait for upstream response before the fetchpatch URL becomes permanent.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label May 18, 2021
@ofborg ofborg bot requested a review from Sohalt May 18, 2021 12:20
@stephank stephank marked this pull request as ready for review May 18, 2021 19:43
@stephank
Copy link
Contributor Author

Upstream merged the PR as-is, so this is good to go. :)

@Mic92 Mic92 merged commit f4e14c1 into NixOS:master May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sohalt Sohalt Awaiting requested review from Sohalt

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@stephank @Mic92